Skip to content

Commit 85f8bb9

Browse files
committed
refactor: use public API
1 parent 33dc4fe commit 85f8bb9

File tree

3 files changed

+10
-17
lines changed

3 files changed

+10
-17
lines changed

lib/Server.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const internalIp = require('internal-ip');
88
const killable = require('killable');
99
const express = require('express');
1010
const { validate } = require('schema-utils');
11+
const webpackDevMiddleware = require('webpack-dev-middleware');
1112
const normalizeOptions = require('./utils/normalizeOptions');
1213
const colors = require('./utils/colors');
1314
const routes = require('./utils/routes');
@@ -151,8 +152,6 @@ class Server {
151152
}
152153

153154
setupDevMiddleware() {
154-
const webpackDevMiddleware = require('webpack-dev-middleware');
155-
156155
// middleware for serving webpack bundle
157156
this.middleware = webpackDevMiddleware(
158157
this.compiler,
@@ -1037,16 +1036,10 @@ class Server {
10371036
}
10381037

10391038
serveMagicHtml(req, res, next) {
1040-
const getFilenameFromUrl =
1041-
require('webpack-dev-middleware/dist/utils/getFilenameFromUrl').default;
1042-
10431039
const _path = req.path;
10441040

10451041
try {
1046-
const filename = getFilenameFromUrl(
1047-
this.middleware.context,
1048-
`${_path}.js`
1049-
);
1042+
const filename = webpackDevMiddleware.getFilenameFromUrl(`${_path}.js`);
10501043
const isFile = this.middleware.context.outputFileSystem
10511044
.statSync(filename)
10521045
.isFile();

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"spdy": "^4.0.2",
5959
"strip-ansi": "^6.0.0",
6060
"url": "^0.11.0",
61-
"webpack-dev-middleware": "^4.2.0",
61+
"webpack-dev-middleware": "^4.3.0",
6262
"ws": "^7.4.5"
6363
},
6464
"devDependencies": {

0 commit comments

Comments
 (0)