Skip to content

Commit 92a020c

Browse files
test: update
1 parent cbf2a6d commit 92a020c

File tree

3 files changed

+29
-20
lines changed

3 files changed

+29
-20
lines changed

test/e2e/entry.test.js

Lines changed: 29 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,26 @@ const runBrowser = require('../helpers/run-browser');
88
const port = require('../ports-map').entry;
99
const isWebpack5 = require('../helpers/isWebpack5');
1010

11+
const HOT_ENABLED_MESSAGE =
12+
'[webpack-dev-server] Hot Module Replacement enabled.';
13+
const LIVE_RELOAD_ENABLED_MESSAGE =
14+
'[webpack-dev-server] Hot Module Replacement enabled.';
15+
16+
const waitForConsoleLogFinished = async (consoleLogs) => {
17+
await new Promise((resolve) => {
18+
const interval = setInterval(() => {
19+
if (
20+
consoleLogs.includes(HOT_ENABLED_MESSAGE) &&
21+
consoleLogs.includes(LIVE_RELOAD_ENABLED_MESSAGE)
22+
) {
23+
clearInterval(interval);
24+
25+
resolve();
26+
}
27+
}, 0);
28+
});
29+
};
30+
1131
describe('entry', () => {
1232
const entryFirst = path.resolve(
1333
__dirname,
@@ -346,7 +366,7 @@ describe('entry', () => {
346366

347367
page
348368
.on('console', (message) => {
349-
consoleMessages.push(message);
369+
consoleMessages.push(message.text());
350370
})
351371
.on('pageerror', (error) => {
352372
pageErrors.push(error);
@@ -357,11 +377,9 @@ describe('entry', () => {
357377
});
358378
await page.addScriptTag({ url: `http://127.0.0.1:${port}/runtime.js` });
359379
await page.addScriptTag({ url: `http://127.0.0.1:${port}/foo.js` });
360-
await page.waitForFunction(() => window.fooChunkLoaded);
380+
await waitForConsoleLogFinished(consoleMessages);
361381

362-
expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
363-
'console messages'
364-
);
382+
expect(consoleMessages).toMatchSnapshot('console messages');
365383
expect(pageErrors).toMatchSnapshot('page errors');
366384

367385
await browser.close();
@@ -410,13 +428,12 @@ describe('entry', () => {
410428
});
411429

412430
const { page, browser } = await runBrowser();
413-
414431
const pageErrors = [];
415432
const consoleMessages = [];
416433

417434
page
418435
.on('console', (message) => {
419-
consoleMessages.push(message);
436+
consoleMessages.push(message.text());
420437
})
421438
.on('pageerror', (error) => {
422439
pageErrors.push(error);
@@ -427,11 +444,9 @@ describe('entry', () => {
427444
});
428445
await page.addScriptTag({ url: `http://127.0.0.1:${port}/runtime.js` });
429446
await page.addScriptTag({ url: `http://127.0.0.1:${port}/bar.js` });
430-
await page.waitForFunction(() => window.barChunkLoaded);
447+
await waitForConsoleLogFinished(consoleMessages);
431448

432-
expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
433-
'console messages'
434-
);
449+
expect(consoleMessages).toMatchSnapshot('console messages');
435450
expect(pageErrors).toMatchSnapshot('page errors');
436451

437452
await browser.close();
@@ -486,7 +501,7 @@ describe('entry', () => {
486501

487502
page
488503
.on('console', (message) => {
489-
consoleMessages.push(message);
504+
consoleMessages.push(message.text());
490505
})
491506
.on('pageerror', (error) => {
492507
pageErrors.push(error);
@@ -497,11 +512,9 @@ describe('entry', () => {
497512
});
498513
await page.addScriptTag({ url: `http://127.0.0.1:${port}/bar.js` });
499514
await page.addScriptTag({ url: `http://127.0.0.1:${port}/foo.js` });
500-
await page.waitForFunction(() => window.fooChunkLoaded);
515+
await waitForConsoleLogFinished(consoleMessages);
501516

502-
expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
503-
'console messages'
504-
);
517+
expect(consoleMessages).toMatchSnapshot('console messages');
505518
expect(pageErrors).toMatchSnapshot('page errors');
506519

507520
await browser.close();

test/fixtures/client-config/bar.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
'use strict';
22

33
console.log('Bar.');
4-
5-
window.barChunkLoaded = true;

test/fixtures/client-config/foo.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
'use strict';
22

33
console.log('Hey.');
4-
5-
window.fooChunkLoaded = true;

0 commit comments

Comments
 (0)