Skip to content

Commit 975c719

Browse files
authored
fix: improve error handling for WebsocketServer (#5038)
1 parent 48f56d5 commit 975c719

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

lib/servers/WebsocketServer.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,17 @@ module.exports = class WebsocketServer extends BaseServer {
9595
client.on("close", () => {
9696
this.clients.splice(this.clients.indexOf(client), 1);
9797
});
98+
99+
// TODO: add a test case for this - https://github.com/webpack/webpack-dev-server/issues/5018
100+
client.on(
101+
"error",
102+
/**
103+
* @param {Error} err
104+
*/
105+
(err) => {
106+
this.server.logger.error(err.message);
107+
},
108+
);
98109
},
99110
);
100111

0 commit comments

Comments
 (0)