Skip to content

Commit f6f665d

Browse files
fix: webpack v4 test
1 parent 9129113 commit f6f665d

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

test/e2e/progress.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ describe('progress', () => {
5151
.on('console', (message) => {
5252
consoleMessages.push(message);
5353
})
54-
.on('request', (request) => {
55-
if (/\.hot-update\.json$/.test(request.url())) {
54+
.on('request', (requestObj) => {
55+
if (/\.hot-update\.(json|js)$/.test(requestObj.url())) {
5656
doHotUpdate = true;
5757
}
5858
});
@@ -76,7 +76,7 @@ describe('progress', () => {
7676
await browser.close();
7777

7878
const progressConsoleMessage = consoleMessages.filter((message) =>
79-
/^\[webpack-dev-server\] \[[a-zA-Z]+\] [0-9]{1,3}% - /.test(
79+
/^\[webpack-dev-server\] (\[[a-zA-Z]+\] )?[0-9]{1,3}% - /.test(
8080
message.text()
8181
)
8282
);

test/server/utils/DevServerPlugin.test.js

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ describe('DevServerPlugin util', () => {
2525
};
2626
const compiler = webpack(webpackOptions);
2727
const devServerOptions = {
28+
hot: true,
2829
client: {
2930
transport: 'sockjs',
3031
webSocketURL: {},
@@ -38,7 +39,9 @@ describe('DevServerPlugin util', () => {
3839
};
3940

4041
const plugin = new DevServerPlugin(devServerOptions);
42+
4143
plugin.apply(compiler);
44+
4245
getEntries(compiler).then((entries) => {
4346
expect(typeof entries).toEqual('function');
4447

@@ -52,11 +55,11 @@ describe('DevServerPlugin util', () => {
5255
expect(entrySecondRun.main.import.length).toEqual(1);
5356
expect(entrySecondRun.main.import[0]).toEqual('./src-2.js');
5457
} else {
55-
expect(entryFirstRun.length).toEqual(2);
56-
expect(entryFirstRun[1]).toEqual('./src-1.js');
58+
expect(entryFirstRun.length).toEqual(3);
59+
expect(entryFirstRun[2]).toEqual('./src-1.js');
5760

58-
expect(entrySecondRun.length).toEqual(2);
59-
expect(entrySecondRun[1]).toEqual('./src-2.js');
61+
expect(entrySecondRun.length).toEqual(3);
62+
expect(entrySecondRun[2]).toEqual('./src-2.js');
6063
}
6164
done();
6265
})
@@ -78,6 +81,7 @@ describe('DevServerPlugin util', () => {
7881
const compiler = webpack(webpackOptions);
7982

8083
const devServerOptions = {
84+
hot: true,
8185
client: {
8286
transport: 'sockjs',
8387
webSocketURL: {},
@@ -105,11 +109,11 @@ describe('DevServerPlugin util', () => {
105109
expect(entrySecondRun.main.import.length).toEqual(1);
106110
expect(entrySecondRun.main.import[0]).toEqual('./src-2.js');
107111
} else {
108-
expect(entryFirstRun.length).toEqual(2);
109-
expect(entryFirstRun[1]).toEqual('./src-1.js');
112+
expect(entryFirstRun.length).toEqual(3);
113+
expect(entryFirstRun[2]).toEqual('./src-1.js');
110114

111-
expect(entrySecondRun.length).toEqual(2);
112-
expect(entrySecondRun[1]).toEqual('./src-2.js');
115+
expect(entrySecondRun.length).toEqual(3);
116+
expect(entrySecondRun[2]).toEqual('./src-2.js');
113117
}
114118
done();
115119
})

0 commit comments

Comments
 (0)