refactor: server #1847
Merged
refactor: server #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
May 6, 2019
| } else { | ||
| } | ||
|
|
||
| if (!certExists) { |
There was a problem hiding this comment.
Regression in previously refactor, need add tests (will be done in other PR)
alexander-akait
commented
May 6, 2019
| ); | ||
| } | ||
|
|
||
| setupFeatures() { |
There was a problem hiding this comment.
No options, we in class so we can use this
alexander-akait
commented
May 6, 2019
|
|
||
| (this.options.features || defaultFeatures).forEach((feature) => { | ||
| features[feature](); | ||
| }); |
There was a problem hiding this comment.
Also we initialize features in this method (all in one place)
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
- Coverage 89.25% 89.22% -0.03%
==========================================
Files 10 10
Lines 614 622 +8
Branches 186 187 +1
==========================================
+ Hits 548 555 +7
- Misses 54 55 +1
Partials 12 12
Continue to review full report at Codecov.
|
|
/cc @hiroppy I merge to continue working and do release, feel free to feedback and open a issue/send a PR if you find something wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Not required
Motivation / Use-Case
Refactor code (part 1 of 3)
Breaking Changes
No
Additional Info
No