Skip to content

test: static output #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 7, 2020
Merged

test: static output #2913

merged 9 commits into from
Dec 7, 2020

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

tests for static output

Motivation / Use-Case

fixes #2745

Breaking Changes

No

Additional Info

No

@@ -11,5 +12,6 @@ module.exports = {
library: 'SockJS',
libraryTarget: 'umd',
},
target: ['web', 'es5'],
// Workaround for webpack@4 installation
target: webpack.webpack ? ['web', 'es5'] : 'web',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, failed locally installation for webpack@4

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #2913 (6b0ceb2) into master (4666425) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2913   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          37       37           
  Lines        1261     1261           
  Branches      334      334           
=======================================
  Hits         1167     1167           
  Misses         89       89           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4666425...6b0ceb2. Read the comment docs.

@alexander-akait alexander-akait merged commit 2a50946 into master Dec 7, 2020
@alexander-akait alexander-akait deleted the issue-2745 branch December 7, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack output is served from undefined
1 participant