-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test: static output #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: static output #2913
Conversation
85b9a28
to
3dbbaa4
Compare
@@ -11,5 +12,6 @@ module.exports = { | |||
library: 'SockJS', | |||
libraryTarget: 'umd', | |||
}, | |||
target: ['web', 'es5'], | |||
// Workaround for webpack@4 installation | |||
target: webpack.webpack ? ['web', 'es5'] : 'web', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, failed locally installation for webpack@4
Codecov Report
@@ Coverage Diff @@
## master #2913 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 37 37
Lines 1261 1261
Branches 334 334
=======================================
Hits 1167 1167
Misses 89 89
Partials 5 5 Continue to review full report at Codecov.
|
For Bugs and Features; did you add new tests?
tests for
static
outputMotivation / Use-Case
fixes #2745
Breaking Changes
No
Additional Info
No