refactor: remove redundant group declaration #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
previously approved these changes
Feb 4, 2021
anshumanv
previously approved these changes
Feb 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #2988 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 37 37
Lines 1262 1262
Branches 326 326
=======================================
Hits 1166 1166
Misses 91 91
Partials 5 5 Continue to review full report at Codecov.
|
snitin315
dismissed stale reviews from anshumanv and alexander-akait
via
f3a7acd
|
I think we need regexp to remove unnecessary information from snapshots... |
alexander-akait
approved these changes
Feb 6, 2021
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
redundant delcarations.
webpack-clido not use them.Breaking Changes
None
Additional Info
No