refactor: use 'public' directory as default value for 'static' #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3005 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 37 37
Lines 1262 1262
Branches 326 326
=======================================
Hits 1166 1166
Misses 91 91
Partials 5 5
Continue to review full report at Codecov.
|
snitin315
changed the title
|
Seems the cache is broken again 😢 . |
|
@snitin315 Let's merge as is, can you send a PR and switch our testing from snapshots? |
Yes Will do 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
use 'public' directory as default value for 'static'
Breaking Changes
the default directory for
staticwas changed fromstatictopublic.Additional Info
No