Skip to content

test: refactor cli test #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021
Merged

test: refactor cli test #3024

merged 1 commit into from
Feb 18, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Refactor tests.

Motivation / Use-Case

No need for separate test cases of --hot and --no-hot for webpack 4 and webpack-5

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #3024 (0ce622c) into master (7d339d4) will increase coverage by 1.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3024      +/-   ##
==========================================
+ Coverage   90.64%   92.22%   +1.58%     
==========================================
  Files          37       37              
  Lines        1261     1261              
  Branches      327      327              
==========================================
+ Hits         1143     1163      +20     
+ Misses        110       93      -17     
+ Partials        8        5       -3     
Impacted Files Coverage Δ
lib/Server.js 94.44% <0.00%> (-0.23%) ⬇️
lib/utils/routes.js 98.21% <0.00%> (+3.57%) ⬆️
lib/utils/DevServerPlugin.js 100.00% <0.00%> (+26.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d339d4...e60badf. Read the comment docs.

@snitin315 snitin315 merged commit 86d4bf0 into master Feb 18, 2021
@snitin315 snitin315 deleted the test-cli branch February 18, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants