Skip to content

fix(server): throw if multiple instances use the same compiler #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ylemkimon
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

This PR adds a devServer property to the compiler instance, which the server is attached to:

Breaking Changes

N/A

Additional Info

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #3039 (94f1dda) into master (d4c9b8f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3039      +/-   ##
==========================================
+ Coverage   92.30%   92.33%   +0.02%     
==========================================
  Files          37       37              
  Lines        1261     1265       +4     
  Branches      328      329       +1     
==========================================
+ Hits         1164     1168       +4     
  Misses         92       92              
  Partials        5        5              
Impacted Files Coverage Δ
lib/Server.js 94.71% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c9b8f...94f1dda. Read the comment docs.

@ylemkimon ylemkimon closed this Mar 11, 2021
@ylemkimon ylemkimon reopened this Mar 11, 2021
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack compiler cannot be reused across server instances
4 participants