Skip to content

fix: move injectClient and injectHot under client property #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2021
Merged

fix: move injectClient and injectHot under client property #3104

merged 2 commits into from
Mar 26, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

wip

Motivation / Use-Case

Moved injectClient and injectHot properties under client as suggested by @alexander-akait

Breaking Changes

Yes

Additional Info

wip on fixes

@alexander-akait
Copy link
Member

@anshumanv please fix CI

@anshumanv anshumanv marked this pull request as ready for review March 25, 2021 20:37
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #3104 (74125c8) into master (5e05e48) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3104      +/-   ##
==========================================
- Coverage   91.93%   91.78%   -0.16%     
==========================================
  Files          37       37              
  Lines        1290     1290              
  Branches      347      347              
==========================================
- Hits         1186     1184       -2     
- Misses         98      100       +2     
  Partials        6        6              
Impacted Files Coverage Δ
lib/utils/DevServerPlugin.js 97.26% <0.00%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e05e48...74125c8. Read the comment docs.

@anshumanv
Copy link
Member Author

@alexander-akait done

@alexander-akait alexander-akait merged commit ca0b534 into webpack:master Mar 26, 2021
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants