Skip to content

fix: move findPort as static method on Server #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 16, 2021
Merged

fix: move findPort as static method on Server #3296

merged 9 commits into from
May 16, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

existing

Motivation / Use-Case

it will allow to solve regressions after change logic with port

Breaking Changes

nope

Additional Info

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #3296 (b9f1229) into master (fc9028c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3296   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          34       34           
  Lines        1260     1260           
  Branches      357      357           
=======================================
  Hits         1204     1204           
  Misses         52       52           
  Partials        4        4           
Impacted Files Coverage Δ
lib/Server.js 95.73% <100.00%> (+0.11%) ⬆️
lib/utils/findPort.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9028c...b9f1229. Read the comment docs.

@anshumanv
Copy link
Member Author

@alexander-akait @snitin315 👍

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid break old version of CLI

@anshumanv
Copy link
Member Author

Fixed

snitin315
snitin315 previously approved these changes May 15, 2021
@alexander-akait
Copy link
Member

@anshumanv Can you rebase?

@anshumanv
Copy link
Member Author

Done 👍

@anshumanv anshumanv merged commit 9801377 into master May 16, 2021
@anshumanv anshumanv deleted the fp branch May 16, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants