Skip to content

test(server): recreate compiler before each test #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021

Conversation

ylemkimon
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

This is cherry-picked from #3039. As the dev-server will become a plugin (#3251), it'd imply one instance per one compiler, so #3039 wouldn't be necessary.

This PR only fixes the relevant test cases, reusing the compiler across multiple server instances.

Breaking Changes

N/A

Additional Info

Closes #3033 and closes #3039.

@ylemkimon ylemkimon closed this May 18, 2021
@ylemkimon ylemkimon reopened this May 18, 2021
@alexander-akait
Copy link
Member

github actions incident https://www.githubstatus.com/

@ylemkimon

This comment has been minimized.

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #3314 (1d0a3b6) into master (3359732) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3314   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files          34       34           
  Lines        1262     1262           
  Branches      358      358           
=======================================
  Hits         1206     1206           
  Misses         52       52           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3359732...1d0a3b6. Read the comment docs.

@snitin315 snitin315 merged commit 2721ab2 into webpack:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack compiler cannot be reused across server instances
4 participants