Skip to content

refactor: ws var #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2021
Merged

refactor: ws var #3363

merged 2 commits into from
May 29, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

existing

Motivation / Use-Case

consistent

Breaking Changes

no

Additional Info

More after #3291

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #3363 (0ac8909) into master (f5e7f8f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3363   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          33       33           
  Lines        1295     1295           
  Branches      377      377           
=======================================
  Hits         1239     1239           
  Misses         52       52           
  Partials        4        4           
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 97.05% <ø> (ø)
lib/Server.js 96.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e7f8f...0ac8909. Read the comment docs.

Co-authored-by: Nitin Kumar <[email protected]>
@alexander-akait alexander-akait merged commit ad2d197 into master May 29, 2021
@alexander-akait alexander-akait deleted the ref-var branch May 29, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants