Skip to content

refactor: schema #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2021
Merged

refactor: schema #3397

merged 6 commits into from
Jun 9, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jun 7, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Already Present.

Motivation / Use-Case

Move properties to definitions.

Breaking Changes

No

Additional Info

No

@snitin315 snitin315 changed the title [WIP] refactor: schema refactor: schema Jun 7, 2021
@snitin315 snitin315 marked this pull request as ready for review June 7, 2021 04:07
anshumanv
anshumanv previously approved these changes Jun 7, 2021
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rishabh3112
rishabh3112 previously approved these changes Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #3397 (8477269) into master (ca36239) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3397      +/-   ##
==========================================
+ Coverage   95.10%   95.25%   +0.15%     
==========================================
  Files          34       34              
  Lines        1327     1327              
  Branches      390      390              
==========================================
+ Hits         1262     1264       +2     
+ Misses         61       59       -2     
  Partials        4        4              
Impacted Files Coverage Δ
lib/Server.js 95.01% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca36239...8477269. Read the comment docs.

@alexander-akait alexander-akait merged commit 1b0f514 into master Jun 9, 2021
@alexander-akait alexander-akait deleted the refactor-schema branch June 9, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants