Skip to content

test: more cases for webSocketURL #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021
Merged

test: more cases for webSocketURL #3423

merged 2 commits into from
Jun 11, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jun 10, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

more test cases -

  • test port on auto
  • test port on 80
  • client.webSocketURL.port on 0 option
  • host on ipv4

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #3423 (db8d173) into master (7af0f8d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3423   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files          34       34           
  Lines        1346     1346           
  Branches      397      397           
=======================================
  Hits         1279     1279           
  Misses         62       62           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af0f8d...db8d173. Read the comment docs.

@snitin315 snitin315 marked this pull request as ready for review June 10, 2021 03:41
@snitin315
Copy link
Member Author

It looks like for port 80 case we need root privilege on Github actions.

@alexander-akait alexander-akait merged commit 68e2f06 into master Jun 11, 2021
@alexander-akait alexander-akait deleted the test-e2e branch June 11, 2021 14:15
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants