refactor: rename properties #3445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested review from
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
snitin315
previously approved these changes
Jun 16, 2021
anshumanv
previously approved these changes
Jun 16, 2021
alexander-akait
dismissed stale reviews from anshumanv and snitin315
via
1993769
alexander-akait
force-pushed
the
refactor-code
branch
from
168d893 to
1993769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
refactor name of properties
Motivation / Use-Case
Better naming
Breaking Changes
In theory yes, if you use properties
Additional Info
We still need refactor our
servers, I will do it late