Skip to content

fix: migrate wsUrl host option to hostname #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 21, 2021
Merged

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

existing

Motivation / Use-Case

compliant with URL spec

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #3456 (a2f689e) into master (13597a2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3456   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files          33       33           
  Lines        1301     1301           
  Branches      403      403           
=======================================
  Hits         1227     1227           
  Misses         67       67           
  Partials        7        7           
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/utils/normalizeOptions.js 98.41% <ø> (ø)
lib/Server.js 95.23% <100.00%> (ø)
lib/utils/DevServerPlugin.js 97.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13597a2...a2f689e. Read the comment docs.

@anshumanv
Copy link
Member Author

@alexander-akait CI green

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@alexander-akait alexander-akait merged commit 52c3d69 into master Jun 21, 2021
@alexander-akait alexander-akait deleted the ws-hostname branch June 21, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants