Skip to content

refactor: tests #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2021
Merged

refactor: tests #3462

merged 2 commits into from
Jun 21, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

it is tests

Motivation / Use-Case

migrated on async await to avoid sync problems

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #3462 (ad376d0) into master (13597a2) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3462      +/-   ##
==========================================
- Coverage   94.31%   94.23%   -0.08%     
==========================================
  Files          33       33              
  Lines        1301     1301              
  Branches      403      403              
==========================================
- Hits         1227     1226       -1     
- Misses         67       68       +1     
  Partials        7        7              
Impacted Files Coverage Δ
lib/servers/SockJSServer.js 90.69% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13597a2...ad376d0. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-akait
Copy link
Member

Great job, thanks

@alexander-akait alexander-akait merged commit d13a058 into master Jun 21, 2021
@alexander-akait alexander-akait deleted the ref-test branch June 21, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants