Skip to content

docs: update examples #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2021
Merged

docs: update examples #3505

merged 2 commits into from
Jul 2, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Update examples to use --open-target <url>, --open-target is not boolean anymore after #3496.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #3505 (190b4ba) into master (0020f3e) will decrease coverage by 0.01%.
The diff coverage is 95.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3505      +/-   ##
==========================================
- Coverage   94.35%   94.34%   -0.02%     
==========================================
  Files          26       20       -6     
  Lines        1276     1291      +15     
  Branches      402      417      +15     
==========================================
+ Hits         1204     1218      +14     
- Misses         66       68       +2     
+ Partials        6        5       -1     
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/Server.js 93.68% <90.60%> (-0.63%) ⬇️
client-src/index.js 88.23% <100.00%> (+5.04%) ⬆️
client-src/utils/createSocketURL.js 100.00% <100.00%> (+3.57%) ⬆️
client-src/utils/parseURL.js 90.00% <100.00%> (-10.00%) ⬇️
client-src/utils/reloadApp.js 82.60% <100.00%> (-4.35%) ⬇️
lib/servers/SockJSServer.js 95.23% <100.00%> (+4.54%) ⬆️
lib/servers/WebsocketServer.js 89.47% <100.00%> (-7.90%) ⬇️
lib/utils/DevServerPlugin.js 98.61% <100.00%> (+1.01%) ⬆️
lib/utils/normalizeOptions.js 97.17% <100.00%> (+0.62%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67aaaf7...190b4ba. Read the comment docs.

@alexander-akait alexander-akait merged commit bd413c7 into webpack:master Jul 2, 2021
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change --open-target on --open as before, it is most usage and simply

@snitin315
Copy link
Member Author

Yes, will do.

@snitin315 snitin315 deleted the docs/open-target branch July 3, 2021 00:25
@snitin315 snitin315 mentioned this pull request Jul 3, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants