Skip to content

refactor: avoid unnecessary arguments to methods #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Already present

Motivation / Use-Case

avoid unnecessary or redundant arguments to methods

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #3616 (27da31b) into master (a71cc03) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3616      +/-   ##
==========================================
- Coverage   94.02%   93.87%   -0.16%     
==========================================
  Files          15       15              
  Lines        1289     1290       +1     
  Branches      443      443              
==========================================
- Hits         1212     1211       -1     
- Misses         70       72       +2     
  Partials        7        7              
Impacted Files Coverage Δ
lib/Server.js 93.85% <100.00%> (+<0.01%) ⬆️
lib/servers/WebsocketServer.js 91.66% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71cc03...27da31b. Read the comment docs.

@snitin315 snitin315 merged commit 1841c58 into master Aug 14, 2021
@snitin315 snitin315 deleted the refactor-adjust-code branch August 14, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants