Skip to content

docs: move overlay, progress, and webSocketURL examples to client #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

move overlay and progress examples to client. Improve examples directory structure, more like schema.

Breaking Changes

None

Additional Info

In the future, we will add more examples for all client properties so it is better to structure them together.

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #3721 (3a21c48) into master (8a3f0d8) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3721      +/-   ##
==========================================
+ Coverage   93.20%   93.35%   +0.15%     
==========================================
  Files          15       15              
  Lines        1324     1324              
  Branches      458      458              
==========================================
+ Hits         1234     1236       +2     
+ Misses         83       81       -2     
  Partials        7        7              
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 97.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3f0d8...3a21c48. Read the comment docs.

@snitin315 snitin315 merged commit 20b4450 into master Aug 22, 2021
@snitin315 snitin315 deleted the docs-client-examples branch August 22, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant