Skip to content

refactor(Server): remove redundant inner functions #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Aug 26, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

This PR refactors Server.js, removing redundant inner functions introduced in #3714.

Breaking Changes

No

Additional Info

@ylemkimon ylemkimon changed the title refactor(Server): remove redundant anonymous functions refactor(Server): remove redundant lambdas Aug 26, 2021
@ylemkimon ylemkimon changed the title refactor(Server): remove redundant lambdas refactor(Server): remove redundant inner functions Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #3750 (25ab65a) into master (88dae29) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3750      +/-   ##
==========================================
- Coverage   92.90%   92.88%   -0.02%     
==========================================
  Files          14       14              
  Lines        1324     1321       -3     
  Branches      465      463       -2     
==========================================
- Hits         1230     1227       -3     
  Misses         87       87              
  Partials        7        7              
Impacted Files Coverage Δ
lib/Server.js 93.84% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88dae29...25ab65a. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexander-akait alexander-akait merged commit d4282dc into webpack:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants