Skip to content

ci: fix puppeteer flakiness #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

ci: fix puppeteer flakiness #3999

merged 1 commit into from
Nov 2, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

refactor test

Motivation / Use-Case

Fix #3964

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #3999 (5f20ee9) into master (6d060ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3999   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          14       14           
  Lines        1406     1406           
  Branches      516      516           
=======================================
  Hits         1302     1302           
  Misses         96       96           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d060ed...5f20ee9. Read the comment docs.

@snitin315 snitin315 marked this pull request as ready for review November 2, 2021 03:01
@snitin315
Copy link
Member Author

Three consecutive attempts were successful. I think we can merge and see it in action.

https://github.com/webpack/webpack-dev-server/actions/runs/1410331816/attempts/1
https://github.com/webpack/webpack-dev-server/actions/runs/1410331816/attempts/2
https://github.com/webpack/webpack-dev-server/actions/runs/1410331816/attempts/3

@snitin315 snitin315 changed the title ci: fix ci: fix puppeteer flakiness Nov 2, 2021
@alexander-akait alexander-akait merged commit 2b42431 into master Nov 2, 2021
@alexander-akait alexander-akait deleted the ci-puppeteer-fix branch November 2, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Protocol error (Network.setUserAgentOverride): Target closed. in CI
2 participants