Skip to content

fix: schema for server option #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: schema for server option #4000

merged 1 commit into from
Nov 2, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

server can not be any string because we use it to require a node module.

this.server = require(this.options.server.type).createServer(

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #4000 (7ac9d6b) into master (2b42431) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4000      +/-   ##
==========================================
- Coverage   92.74%   92.60%   -0.15%     
==========================================
  Files          14       14              
  Lines        1406     1406              
  Branches      516      516              
==========================================
- Hits         1304     1302       -2     
- Misses         94       96       +2     
  Partials        8        8              
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 91.42% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b42431...7ac9d6b. Read the comment docs.

lib/options.json Outdated
"cli": {
"exclude": true
}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory developer can use type: "own-server-package" which compatibility with connect, so let's add test for this case (just reexport express for tests)

@alexander-akait alexander-akait merged commit 61e572e into master Nov 2, 2021
@alexander-akait alexander-akait deleted the fix-server-schema branch November 2, 2021 15:54
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants