Make webpack-dev-server npm compatible with [email protected] #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `webpack-dev-server` requires webpack@^2.2.0 as a dev / peer dependency. This allows anything greater or equal to 2.2.0 instead.
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 4 4
Lines 463 463
Branches 139 139
=======================================
Hits 334 334
Misses 129 129Continue to review full report at Codecov.
|
|
Duplicate of #946 It's on their radar but not yet merged / released. |
|
closing citing #946. new version was rolled out on the 7th |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
webpack-dev-serverrequires webpack@^2.2.0 as a dev / peer dependency. This allows anything greater or equal to 2.2.0 instead.What kind of change does this PR introduce?
Version fix for npm compatibility.
Did you add or update the
examples/?No, seems unnecessary.
Summary
Currently, npm throws messages about webpack-dev-server not supporting [email protected]. This updates the version range to support webpack 2 or beyond.
Does this PR introduce a breaking change?
To my knowledge, no it does not.