Allow symlink to files to be downloaded (KnpLabs#751)

acrobat · Nyholm · commit 7e07e4a62d61 · 2018-10-14T14:34:37.000+02:00
diff --git a/lib/Github/Api/Repository/Contents.php b/lib/Github/Api/Repository/Contents.php
@@ -276,8 +276,8 @@ public function download($username, $repository, $path, $reference = null)
     {
         $file = $this->show($username, $repository, $path, $reference);
 
-        if (!isset($file['type']) || 'file' !== $file['type']) {
-            throw new InvalidArgumentException(sprintf('Path "%s" is not a file.', $path));
+        if (!isset($file['type']) || !in_array($file['type'], ['file', 'symlink'], true)) {
+            throw new InvalidArgumentException(sprintf('Path "%s" is not a file or a symlink to a file.', $path));
         }
 
         if (!isset($file['content'])) {

Original file line number	Diff line number	Diff line change
`@@ -276,8 +276,8 @@ public function download($username, $repository, $path, $reference = null)`
`276`	`276`	`{`
`277`	`277`	`$file = $this->show($username, $repository, $path, $reference);`
`278`	`278`
`279`		`- if (!isset($file['type']) \|\| 'file' !== $file['type']) {`
`280`		`- throw new InvalidArgumentException(sprintf('Path "%s" is not a file.', $path));`
	`279`	`+ if (!isset($file['type']) \|\| !in_array($file['type'], ['file', 'symlink'], true)) {`
	`280`	`+ throw new InvalidArgumentException(sprintf('Path "%s" is not a file or a symlink to a file.', $path));`
`281`	`281`	`}`
`282`	`282`
`283`	`283`	`if (!isset($file['content'])) {`