[iOS] Fabric renderer fix #7867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
asafkorem
approved these changes
Apr 24, 2024
1 task
|
Released with 7.39.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After migration to RN73,
RNNReactViewnow extends fromRCTSurfaceHostingProxyRootViewand uses newinitWithBridge:implementation (with Fabric) withRCTFabricSurfaceinstance. IninitWithBridge:method, we call[super initWithSurface:surface sizeMeasureMode:sizeMeasureMode], but this method located inRCTSurfaceHostingView(parent forRCTSurfaceHostingProxyRootView) and does not call[surface start](unlikeRCTSurfaceHostingProxyRootView[super initWithSurface:surface]that calls it, but it does not allow us to specifyRCTSurfaceSizeMeasureMode), so all we need to do is to call[surface start]afterRNNReactViewinit.Also I created Expo plugin for this wonderful library, it supports SDK 49 and SDK 50 (RN 72 & 73): RNN Expo Plugin