Fix lint issues

Author: ethanshar

src/commons/__tests__/modifiers.spec.js

@@ -45,19 +45,18 @@ describe('Modifiers', () => {
       expect(uut.extractTypographyValue({
         text40: true,
         text70: false
-      }),).toEqual(Typography.text40);
+      })).toEqual(Typography.text40);
     });
 
     it('should prioritize last typography modifier prop in case there is more than one', () => {
       expect(uut.extractTypographyValue({
         text40: true,
         text70: true
-      }),).toEqual(Typography.text70);
+      })).toEqual(Typography.text70);
       expect(uut.extractTypographyValue({
         text70: true,
         text40: true
-      }),).toEqual(Typography.text40);
-      
+      })).toEqual(Typography.text40);
     });
 
     it('should return value of the custom made typography', () => {
@@ -67,17 +66,20 @@ describe('Modifiers', () => {
       expect(uut.extractTypographyValue({
         text40: true,
         customTypography: true
-      }),).toEqual({...Typography.text40, ...customTypography});
+      })).toEqual({...Typography.text40, ...customTypography});
       expect(uut.extractTypographyValue({
         customTypography: true,
         text40: true
-      }),).toEqual({...customTypography, ...Typography.text40});
+      })).toEqual({...customTypography, ...Typography.text40});
     });
 
     it('should merge typography modifiers', () => {
       const bold = {fontWeight: 'bold'};
       Typography.loadTypographies({bold});
-      expect(uut.extractTypographyValue({text70: true, bold: true})).toEqual({...Typography.text70, fontWeight: 'bold'});
+      expect(uut.extractTypographyValue({text70: true, bold: true})).toEqual({
+        ...Typography.text70,
+        fontWeight: 'bold'
+      });
     });
   });
 
@@ -91,7 +93,7 @@ describe('Modifiers', () => {
         'paddingB-15': true,
         'paddingH-20': true,
         'paddingV-15': true
-      }),).toEqual({
+      })).toEqual({
         padding: 25,
         paddingLeft: 15,
         paddingTop: 10,
@@ -125,7 +127,7 @@ describe('Modifiers', () => {
         'marginB-15': true,
         'marginH-20': true,
         'marginV-15': true
-      }),).toEqual({
+      })).toEqual({
         margin: 25,
         marginLeft: 15,
         marginTop: 10,
@@ -221,7 +223,13 @@ describe('Modifiers', () => {
       expect(uut.extractPositionStyle({abs: true})).toEqual({position: 'absolute'});
     });
     it('should return absolute fill object style', () => {
-      expect(uut.extractPositionStyle({absF: true})).toEqual({position: 'absolute', top: 0, left: 0, right: 0, bottom: 0});
+      expect(uut.extractPositionStyle({absF: true})).toEqual({
+        position: 'absolute',
+        top: 0,
+        left: 0,
+        right: 0,
+        bottom: 0
+      });
     });
     it('should return absolute with top value', () => {
       expect(uut.extractPositionStyle({absT: true})).toEqual({position: 'absolute', top: 0});
@@ -241,7 +249,6 @@ describe('Modifiers', () => {
     it('should return absolute with horizontal values', () => {
       expect(uut.extractPositionStyle({absH: true})).toEqual({position: 'absolute', left: 0, right: 0});
     });
-
   });
 
   describe('extractFlexStyle - flex modifier', () => {
@@ -299,7 +306,7 @@ describe('Modifiers', () => {
         'paddingL-20': true,
         'bg-red30': true,
         other: 'some-value'
-      }),).toEqual({
+      })).toEqual({
         'paddingL-20': true,
         'bg-red30': true
       });
@@ -308,7 +315,7 @@ describe('Modifiers', () => {
         'margin-50': true,
         'background-blue20': true,
         other: 'some-value'
-      }),).toEqual({
+      })).toEqual({
         'margin-50': true,
         'background-blue20': true
       });
@@ -364,9 +371,9 @@ describe('Modifiers', () => {
       expect(uut.getThemeProps.call(SampleComponent, {test: true})).toEqual({prop1: 'yes', test: true});
       expect(uut.getThemeProps.call(SampleComponent, {test: false})).toEqual({prop1: 'no', test: false});
     });
-    
+
     it('should prioritize forced theme props over user props', () => {
-      ThemeManager.setComponentForcedTheme('SampleComponent', (props) => ({foo: 'forced'}));
+      ThemeManager.setComponentForcedTheme('SampleComponent', () => ({foo: 'forced'}));
       expect(uut.getThemeProps.call(SampleComponent, {foo: 'user-value', other: 'other'})).toEqual({
         foo: 'forced',
         other: 'other'

src/commons/asBaseComponent.tsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import _ from 'lodash';
 //@ts-ignore
 import hoistStatics from 'hoist-non-react-statics';
 //@ts-ignore
@@ -17,7 +16,7 @@ export interface BaseComponentInjectedProps {
 // TODO: find a proper way to inject this type in the private repo
 type ThemeComponent = {
   useCustomTheme?: boolean;
-}
+};
 
 function asBaseComponent<PROPS, STATICS = {}>(WrappedComponent: React.ComponentType<any>): React.ComponentClass<PROPS & ThemeComponent> & STATICS {
   class BaseComponent extends UIComponent {
@@ -31,7 +30,7 @@ function asBaseComponent<PROPS, STATICS = {}>(WrappedComponent: React.ComponentT
 
     static getThemeProps = (props: any, context: any) => {
       return Modifiers.getThemeProps.call(WrappedComponent, props, context);
-    }
+    };
 
     static getDerivedStateFromError(error: any) {
       UIComponent.defaultProps?.onError(error, WrappedComponent.defaultProps);
@@ -46,9 +45,9 @@ function asBaseComponent<PROPS, STATICS = {}>(WrappedComponent: React.ComponentT
       const {forwardedRef, ...others} = themeProps;
       return (
         (this.state.error && UIComponent.defaultProps?.renderError) || (
-          <WrappedComponent {...others} modifiers={modifiers} ref={forwardedRef} />
+          <WrappedComponent {...others} modifiers={modifiers} ref={forwardedRef}/>
         )
-      )
+      );
     }
   }
 

src/commons/baseComponent.js

@@ -74,7 +74,7 @@ export default function baseComponent(usePure) {
     extractContainerStyle(props) {
       let containerStyle = {};
       if (props.containerStyle) {
-        containerStyle = _.pickBy(props.containerStyle, (value, key) => {
+        containerStyle = _.pickBy(props.containerStyle, (_value, key) => {
           return key.includes('margin') || _.includes(['alignSelf', 'transform'], key);
         });
       }

src/commons/modifiers.ts

@@ -245,7 +245,7 @@ export function extractFlexStyle(props: Dictionary<any>): Partial<Record<NativeF
   const keys = Object.keys(props);
   const flexProp = keys.find(item => FLEX_KEY_PATTERN.test(item));
   if (flexProp && props[flexProp] === true) {
-    let [flexKey, flexValue] = flexProp.split('-') as [keyof typeof STYLE_KEY_CONVERTERS, string];
+    const [flexKey, flexValue] = flexProp.split('-') as [keyof typeof STYLE_KEY_CONVERTERS, string];
     const convertedFlexKey = STYLE_KEY_CONVERTERS[flexKey];
     const flexValueAsNumber = _.isEmpty(flexValue) ? 1 : Number(flexValue);
 

src/components/KeyboardAwareScrollView/KeyboardAwareBase.js

@@ -100,7 +100,7 @@ export default class KeyboardAwareBase extends Component {
   _scrollToFocusedTextInput() {
     if (this.props.getTextInputRefs) {
       const textInputRefs = this.props.getTextInputRefs();
-      textInputRefs.some((textInputRef, index, array) => {
+      textInputRefs.some((textInputRef) => {
         const isFocusedFunc = textInputRef.isFocused();
         const isFocused = isFocusedFunc && typeof isFocusedFunc === 'function' ? isFocusedFunc() : isFocusedFunc;
         if (isFocused) {
@@ -132,7 +132,7 @@ export default class KeyboardAwareBase extends Component {
     }
   }
 
-  _onKeyboardWillHide(event) {
+  _onKeyboardWillHide() {
     const keyboardHeight = this.state.keyboardHeight;
     this.setState({keyboardHeight: 0});
 

src/components/actionBar/index.tsx

@@ -1,12 +1,11 @@
 import _ from 'lodash';
-import React, { Component } from 'react';
+import React, {Component} from 'react';
 import {StyleSheet, ViewStyle} from 'react-native';
 import {Colors, Shadows} from '../../style';
 import {asBaseComponent} from '../../commons/new';
 import View from '../view';
 import Button, {ButtonProps} from '../button';
 
-
 /**
  * @description: Quick actions bar, each action support Button component props
  * @modifiers: margin, padding
@@ -15,34 +14,34 @@ import Button, {ButtonProps} from '../button';
  */
 
 export type ActionBarProps = {
-    /**
-     * action bar height
-     */
-    height?: number;
-    /**
-     * action bar background color
-     */
-    backgroundColor?: string;
-    /**
-     * actions for the action bar
-     */
-    actions: ButtonProps[];
-    /**
-     * should action be equally centered
-     */
-    centered?: boolean;
-    /**
-     * use safe area, in case action bar attached to the bottom (default: true)
-     */
-    useSafeArea?: boolean;
-    /**
-     * keep the action bar position relative instead of it absolute position
-     */
-    keepRelative?: boolean;
-    /**
-     * style the action bar
-     */
-    style?: ViewStyle;
+  /**
+   * action bar height
+   */
+  height?: number;
+  /**
+   * action bar background color
+   */
+  backgroundColor?: string;
+  /**
+   * actions for the action bar
+   */
+  actions: ButtonProps[];
+  /**
+   * should action be equally centered
+   */
+  centered?: boolean;
+  /**
+   * use safe area, in case action bar attached to the bottom (default: true)
+   */
+  useSafeArea?: boolean;
+  /**
+   * keep the action bar position relative instead of it absolute position
+   */
+  keepRelative?: boolean;
+  /**
+   * style the action bar
+   */
+  style?: ViewStyle;
 };
 
 class ActionBar extends Component<ActionBarProps> {
@@ -54,10 +53,6 @@ class ActionBar extends Component<ActionBarProps> {
     useSafeArea: true
   };
 
-  constructor(props: ActionBarProps) {
-    super(props);
-  }
-
   styles = createStyles(this.props);
 
   getAlignment(actionIndex: number) {
@@ -90,7 +85,7 @@ class ActionBar extends Component<ActionBarProps> {
 
 export default asBaseComponent<ActionBarProps>(ActionBar);
 
-function createStyles({height, backgroundColor} : any) {
+function createStyles({height, backgroundColor}: any) {
   return StyleSheet.create({
     container: {
       height

src/components/actionSheet/index.js

@@ -161,7 +161,7 @@ export default class ActionSheet extends BaseComponent {
 
   renderActions() {
     const {title, options, cancelButtonIndex, renderAction, optionsStyle} = this.props;
-    const optionsToRender = _.filter(options, (option, index) => index !== cancelButtonIndex);
+    const optionsToRender = _.filter(options, (_option, index) => index !== cancelButtonIndex);
 
     return (
       <View style={[_.isEmpty(title) ? styles.listNoTitle : styles.listWithTitle, optionsStyle]}>