Skip to content

Commit 0d100e1

Browse files
committed
Merge branch 'master' into release
2 parents e36e794 + 26543a3 commit 0d100e1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+1792
-284
lines changed

.flowconfig

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@
88
; Ignore polyfills
99
node_modules/react-native/Libraries/polyfills/.*
1010

11-
; These should not be required directly
12-
; require from fbjs/lib instead: require('fbjs/lib/warning')
13-
node_modules/warning/.*
14-
1511
; Flow doesn't support platforms
1612
.*/Libraries/Utilities/LoadingView.js
1713

14+
exact_by_default=true
15+
1816
[untyped]
1917
.*/node_modules/@react-native-community/cli/.*/.*
2018

@@ -44,10 +42,6 @@ suppress_type=$FlowFixMe
4442
suppress_type=$FlowFixMeProps
4543
suppress_type=$FlowFixMeState
4644

47-
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)
48-
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)?:? #[0-9]+
49-
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
50-
5145
[lints]
5246
sketchy-null-number=warn
5347
sketchy-null-mixed=warn
@@ -70,4 +64,4 @@ untyped-import
7064
untyped-type-import
7165

7266
[version]
73-
^0.122.0
67+
^0.137.0

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8.1.3
1+
14.16.0

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ please use `react-native-ui-lib@^3.0.0`
4040
### Step 1
4141
Load your foundations and presets (colors, typography, spacings, etc...)
4242

43-
```
43+
```js
4444
// FoundationConfig.js
4545

4646
import {Colors, Typography, Spacings} from 'react-native-ui-lib';
@@ -71,7 +71,7 @@ Spacings.loadSpacings({
7171
### Step 2
7272
Set default configurations to your components
7373

74-
```
74+
```js
7575
// ComponentsConfig.js
7676

7777
import {ThemeManager} from 'react-native-ui-lib';
@@ -97,7 +97,7 @@ ThemeManager.setComponentTheme('Button', (props, context) => {
9797
Use it all together.
9898
Your configurations will be applied on uilib components so you can use them easily with [modifiers](https://wix.github.io/react-native-ui-lib/foundation/modifiers).
9999

100-
```
100+
```jsx
101101
// MyScreen.js
102102

103103
import React, {Component} from 'react';

_editorconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Windows files
2+
[*.bat]
3+
end_of_line = crlf

android/app/build.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ def enableHermes = project.ext.react.get("enableHermes", false)
1515

1616
android {
1717
compileSdkVersion rootProject.ext.compileSdkVersion
18+
ndkVersion rootProject.ext.ndkVersion
1819

1920
compileOptions {
2021
sourceCompatibility JavaVersion.VERSION_1_8
@@ -63,11 +64,12 @@ android {
6364
variant.outputs.each { output ->
6465
// For each separate APK per architecture, set a unique version code as described here:
6566
// https://developer.android.com/studio/build/configure-apk-splits.html
67+
// Example: versionCode 1 will generate 1001 for armeabi-v7a, 1002 for x86, etc.
6668
def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4]
6769
def abi = output.getFilter(OutputFile.ABI)
6870
if (abi != null) { // null for the universal-debug, universal-release variants
6971
output.versionCodeOverride =
70-
versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
72+
defaultConfig.versionCode * 1000 + versionCodes.get(abi)
7173
}
7274

7375
}

android/app/src/debug/AndroidManifest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,7 @@
44

55
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
66

7-
<application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning" />
7+
<application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning">
8+
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
9+
</application>
810
</manifest>

android/app/src/main/AndroidManifest.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,5 @@
2121
<category android:name="android.intent.category.LAUNCHER" />
2222
</intent-filter>
2323
</activity>
24-
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
2524
</application>
26-
2725
</manifest>

android/app/src/main/res/values/styles.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<resources>
22

33
<!-- Base application theme. -->
4-
<style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
4+
<style name="AppTheme" parent="Theme.AppCompat.DayNight.NoActionBar">
55
<!-- Customize your theme here. -->
66
<item name="android:textColor">#000000</item>
77
</style>

android/build.gradle

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22

33
buildscript {
44
ext {
5-
buildToolsVersion = "29.0.2"
6-
minSdkVersion = 19
5+
buildToolsVersion = "29.0.3"
6+
minSdkVersion = 21
77
compileSdkVersion = 29
88
targetSdkVersion = 29
9+
ndkVersion = "20.1.5948944"
910
RNNKotlinVersion = "1.3.61" // Or any version above 1.3.x
1011
}
1112
repositories {
@@ -16,7 +17,7 @@ buildscript {
1617
}
1718
dependencies {
1819
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$RNNKotlinVersion"
19-
classpath 'com.android.tools.build:gradle:3.5.3'
20+
classpath("com.android.tools.build:gradle:4.1.0")
2021

2122
// NOTE: Do not place your application dependencies here; they belong
2223
// in the individual module build.gradle files

android/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ android.useAndroidX=true
2121
android.enableJetifier=true
2222

2323
# Version of flipper SDK to use with React Native
24-
FLIPPER_VERSION=0.37.0
24+
FLIPPER_VERSION=0.75.1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.3-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

demo/src/screens/ExampleScreenPresenter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export function renderBooleanGroup(title, options) {
4444
marginR-s2
4545
useCustomTheme
4646
key={key}
47-
textID={key}
47+
testID={key}
4848
value={value}
4949
onValueChange={value => this.setState({[key]: value})}
5050
/>

demo/src/screens/componentScreens/HintsScreen.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ export default class HintsScreen extends Component<HintScreenProps, HintScreenSt
3939
});
4040
};
4141

42+
onHintPressed = () => {
43+
alert('Hint Pressed');
44+
}
45+
4246
render() {
4347
const {
4448
showHint,
@@ -85,6 +89,7 @@ export default class HintsScreen extends Component<HintScreenProps, HintScreenSt
8589
position={showBottomHint ? Hint.positions.BOTTOM : Hint.positions.TOP}
8690
useSideTip={useSideTip}
8791
key={targetPosition}
92+
onPress={this.onHintPressed}
8893
targetFrame={useTargetFrame ? targetFrame : undefined}
8994
// borderRadius={BorderRadiuses.br40}
9095
// edgeMargins={30}

demo/src/screens/componentScreens/PickerScreen.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,6 @@ export default class PickerScreen extends Component {
137137
// );
138138
// }}
139139
// topBarProps={{doneLabel: 'YES', cancelLabel: 'NO'}}
140-
wheelPickerProps={{
141-
style: {width: 200},
142-
color: Colors.green30,
143-
labelStyle: {fontSize: 32, fontFamily: 'sans-serif-condensed-light'},
144-
itemHeight: 55
145-
}}
146-
selectLabelStyle={{color: Colors.green30}}
147-
cancelLabelStyle={{color: Colors.green30}}
148140
>
149141
{_.map(options, option => (
150142
<Picker.Item key={option.value} value={option.value} label={option.label} disabled={option.disabled}/>
@@ -162,7 +154,13 @@ export default class PickerScreen extends Component {
162154
renderCustomModal={this.renderDialog}
163155
>
164156
{_.map(options, option => (
165-
<Picker.Item key={option.value} value={option} label={option.label} labelStyle={Typography.text65} disabled={option.disabled}/>
157+
<Picker.Item
158+
key={option.value}
159+
value={option}
160+
label={option.label}
161+
labelStyle={Typography.text65}
162+
disabled={option.disabled}
163+
/>
166164
))}
167165
</Picker>
168166

@@ -236,7 +234,9 @@ export default class PickerScreen extends Component {
236234
))}
237235
</Picker>
238236

239-
<Text text60 marginT-s5 marginB-s2>Migrated Picker</Text>
237+
<Text text60 marginT-s5 marginB-s2>
238+
Migrated Picker
239+
</Text>
240240

241241
<Picker
242242
migrate

demo/src/screens/componentScreens/SegmentedControlScreen.tsx

Lines changed: 34 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ const segments = {
1414
},
1515
{label: 'Short'}
1616
],
17-
forth: [{label: 'With'}, {label: 'Custom'}, {label: 'Colors'}]
17+
forth: [{label: 'With'}, {label: 'Custom'}, {label: 'Colors'}],
18+
fifth: [{label: 'Full'}, {label: 'Width'}],
19+
sixth: [{label: 'Full'}, {label: 'Width'}, {label: 'With'}, {label: 'A'}, {label: 'Very Long Segment'}]
1820
};
1921

2022
const SegmentedControlScreen = () => {
@@ -23,30 +25,42 @@ const SegmentedControlScreen = () => {
2325
};
2426

2527
return (
26-
<View flex bottom padding-20>
27-
<View flex center>
28-
<SegmentedControl onChangeIndex={(index: number) => onChangeIndex('first', index)} segments={segments.first}/>
28+
<View flex bottom padding-page>
29+
<View flex centerV>
30+
<View center>
31+
<SegmentedControl onChangeIndex={(index: number) => onChangeIndex('first', index)} segments={segments.first}/>
32+
<SegmentedControl
33+
onChangeIndex={(index: number) => onChangeIndex('second', index)}
34+
containerStyle={styles.container}
35+
segments={segments.second}
36+
initialIndex={2}
37+
/>
38+
<SegmentedControl
39+
onChangeIndex={(index: number) => onChangeIndex('third', index)}
40+
containerStyle={styles.container}
41+
activeColor={Colors.red30}
42+
segments={segments.third}
43+
/>
44+
<SegmentedControl
45+
onChangeIndex={(index: number) => onChangeIndex('forth', index)}
46+
containerStyle={styles.container}
47+
segments={segments.forth}
48+
activeColor={Colors.grey10}
49+
borderRadius={BorderRadiuses.br20}
50+
backgroundColor={Colors.grey10}
51+
activeBackgroundColor={Colors.grey40}
52+
inactiveColor={Colors.grey70}
53+
/>
54+
</View>
2955
<SegmentedControl
30-
onChangeIndex={(index: number) => onChangeIndex('second', index)}
31-
containerStyle={styles.container}
32-
segments={segments.second}
33-
initialIndex={2}
34-
/>
35-
<SegmentedControl
36-
onChangeIndex={(index: number) => onChangeIndex('third', index)}
3756
containerStyle={styles.container}
38-
activeColor={Colors.red30}
39-
segments={segments.third}
57+
onChangeIndex={(index: number) => onChangeIndex('second', index)}
58+
segments={segments.fifth}
4059
/>
4160
<SegmentedControl
42-
onChangeIndex={(index: number) => onChangeIndex('forth', index)}
4361
containerStyle={styles.container}
44-
segments={segments.forth}
45-
activeColor={Colors.grey10}
46-
borderRadius={BorderRadiuses.br20}
47-
backgroundColor={Colors.grey10}
48-
activeBackgroundColor={Colors.grey40}
49-
inactiveColor={Colors.grey70}
62+
onChangeIndex={(index: number) => onChangeIndex('second', index)}
63+
segments={segments.sixth}
5064
/>
5165
</View>
5266
<Text text40 dark10>

demo/src/screens/componentScreens/StepperScreen.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,17 @@ export default class StepperScreen extends Component {
4242
onValueChange={count => this.setState({itemsCount: count})}
4343
initialValue={1}
4444
/>
45+
46+
<View row center>
47+
<Text text60 primary>Count: </Text>
48+
<Stepper
49+
step={0.5}
50+
min={1}
51+
max={50}
52+
onValueChange={count => this.setState({itemsCount: count})}
53+
initialValue={1}
54+
/>
55+
</View>
4556
</View>
4657
</ScrollView>
4758
);

0 commit comments

Comments
 (0)