Dialog and Panning - allow union type for direction (#1635)

Author: M-i-k-e-l

generatedTypes/src/components/dialog/DialogDismissibleView.d.ts

@@ -31,7 +31,7 @@ declare const DialogDismissibleView: {
     (props: Props): JSX.Element;
     displayName: string;
     defaultProps: {
-        direction: PanningDirections;
+        direction: import("../panningViews/panningProvider").PanningDirectionsEnum;
         onDismiss: () => void;
     };
 };

generatedTypes/src/components/panningViews/panningProvider.d.ts

@@ -1,10 +1,12 @@
 import { Component } from 'react';
-export declare enum PanningDirections {
+export declare enum PanningDirectionsEnum {
     UP = "up",
     DOWN = "down",
     LEFT = "left",
     RIGHT = "right"
 }
+export declare type PanningDirectionsUnion = `${PanningDirectionsEnum}`;
+export declare type PanningDirections = PanningDirectionsEnum | PanningDirectionsUnion;
 export interface PanLocationProps {
     left?: number;
     top?: number;
@@ -31,7 +33,7 @@ interface State {
  */
 export default class PanningProvider extends Component<any, State> {
     static displayName: string;
-    static Directions: typeof PanningDirections;
+    static Directions: typeof PanningDirectionsEnum;
     constructor(props: any);
     getProviderContextValue: () => {
         onPanStart: () => void;

src/components/dialog/DialogDismissibleView.tsx

@@ -199,9 +199,11 @@ const DialogDismissibleView = (props: Props) => {
   }, []);
 
   const resetToShown = useCallback((left: number, top: number, direction: PanningDirections) => {
-    const toValue = [PanningProvider.Directions.LEFT, PanningProvider.Directions.RIGHT].includes(direction)
-      ? 1 + left / hiddenLocation.current.left
-      : 1 + top / hiddenLocation.current.top;
+    const toValue =
+        //@ts-expect-error
+        [PanningProvider.Directions.LEFT, PanningProvider.Directions.RIGHT].includes(direction)
+          ? 1 + left / hiddenLocation.current.left
+          : 1 + top / hiddenLocation.current.top;
 
     animateTo(toValue);
   },

src/components/panningViews/panningProvider.tsx

@@ -1,14 +1,17 @@
 import React, {Component} from 'react';
 import PanningContext from './panningContext';
 
-
-export enum PanningDirections {
+export enum PanningDirectionsEnum {
   UP = 'up',
   DOWN = 'down',
   LEFT = 'left',
   RIGHT = 'right'
 }
 
+export type PanningDirectionsUnion = `${PanningDirectionsEnum}`;
+
+export type PanningDirections = PanningDirectionsEnum | PanningDirectionsUnion;
+
 export interface PanLocationProps {
   left?: number;
   top?: number;
@@ -39,7 +42,7 @@ interface State {
  */
 export default class PanningProvider extends Component<any, State> {
   static displayName = 'IGNORE';
-  static Directions = PanningDirections;
+  static Directions = PanningDirectionsEnum;
 
   constructor(props: any) {
     super(props);