TabBarItem - remove deprecated prop (#1554)

Author: Inbal-Tish

generatedTypes/src/components/tabBar/TabBarItem.d.ts

@@ -23,9 +23,8 @@ export interface TabBarItemProps {
      */
     labelStyle?: StyleProp<TextStyle>;
     /**
-     * Badge component props to display next the item label
+     * Badge component's props to display next the item label
      */
-    badge?: BadgeProps;
     badgeProps?: BadgeProps;
     /**
      * Pass to render a leading element

src/components/tabBar/TabBarItem.tsx

@@ -10,7 +10,6 @@ import {
   ViewStyle,
   TextStyle
 } from 'react-native';
-import {LogService} from '../../services';
 import {Constants} from '../../helpers';
 import {Colors, Typography, Spacings} from '../../style';
 import {asBaseComponent} from '../../commons/new';
@@ -20,6 +19,7 @@ import Text from '../text';
 import Image from '../image';
 import Badge, {BadgeProps} from '../badge';
 
+
 const INDICATOR_HEIGHT = 2;
 const INDICATOR_BG_COLOR = Colors.primary;
 const HORIZONTAL_PADDING = Constants.isTablet ? Spacings.s7 : Spacings.s5;
@@ -46,9 +46,8 @@ export interface TabBarItemProps {
    */
   labelStyle?: StyleProp<TextStyle>;
   /**
-   * Badge component props to display next the item label
+   * Badge component's props to display next the item label
    */
-  badge?: BadgeProps; //TODO: remove after deprecation
   badgeProps?: BadgeProps;
   /**
    * Pass to render a leading element
@@ -131,10 +130,6 @@ class TabBarItem extends PureComponent<TabBarItemProps, State> {
       indicatorOpacity: props.selected ? new Animated.Value(1) : new Animated.Value(0),
       selected: props.selected
     };
-
-    if (!_.isEmpty(props.badge)) {
-      LogService.deprecationWarn({component: 'TabBarItem', oldProp: 'badge', newProp: 'badgeProps'});
-    }
   }
 
   componentDidUpdate(prevProps: TabBarItemProps) {
@@ -193,7 +188,6 @@ class TabBarItem extends PureComponent<TabBarItemProps, State> {
       label,
       labelStyle,
       badgeProps,
-      badge,
       leadingAccessory,
       trailingAccessory,
       uppercase,
@@ -212,8 +206,7 @@ class TabBarItem extends PureComponent<TabBarItemProps, State> {
     const iconTint = iconColor || this.getColorFromStyle(labelStyle) || this.getColorFromStyle(styles.label);
     const iconSelectedTint =
       iconSelectedColor || this.getColorFromStyle(selectedLabelStyle) || this.getColorFromStyle(styles.selectedLabel);
-    const badgeFinalProps = badgeProps || badge;
-    const badgeSize = _.get(badgeFinalProps, 'size', 16);
+    const badgeSize = _.get(badgeProps, 'size', 16);
 
     return (
       <TouchableOpacity
@@ -247,12 +240,12 @@ class TabBarItem extends PureComponent<TabBarItemProps, State> {
             </Text>
           )}
           {children}
-          {!_.isNil(badgeFinalProps) && (
+          {!_.isNil(badgeProps) && (
             <Badge
               backgroundColor={Colors.red30}
-              {...badgeFinalProps}
+              {...badgeProps}
               size={badgeSize}
-              containerStyle={[styles.badge, badgeFinalProps.containerStyle]}
+              containerStyle={[styles.badge, badgeProps.containerStyle]}
             />
           )}
           {trailingAccessory}