Skip to content

Commit 3f964a2

Browse files
authored
Picker - usePickerLabel - revert fix fro string value (#3169)
1 parent 7d83fec commit 3f964a2

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/components/picker/helpers/__tests__/usePickerLabel.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ describe('usePickerLabel hook tests', () => {
6868
expect(sut.result.current.label).toEqual('Red');
6969
});
7070

71-
it('expect label to equal value when no items passed', () => {
71+
it('expect label to equal empty string when no items passed', () => {
7272
const sut = makeSUT({items: undefined, value: 'Some string', getLabel: undefined});
73-
expect(sut.result.current.label).toEqual('Some string');
73+
expect(sut.result.current.label).toEqual('');
7474
});
7575
});

src/components/picker/helpers/usePickerLabel.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,8 @@ const usePickerLabel = (props: UsePickerLabelProps) => {
2929
return getLabelsFromArray(value);
3030
}
3131

32-
if (!_.isEmpty(items)) {
33-
const selectedItem = _.find(items, {value});
34-
return _.get(selectedItem, 'label');
35-
}
36-
37-
if (typeof value === 'string') {
38-
return value;
39-
}
32+
const selectedItem = _.find(items, {value});
33+
return _.get(selectedItem, 'label');
4034
}, [getLabel, getLabelsFromArray, items]);
4135

4236
const accessibilityInfo = useMemo(() => {

0 commit comments

Comments
 (0)