fix missing dialog props (such as onShow) (#1715)

* fix missing dialog props (such as onShow)

* use modalProps instead of 'others'

* typing

Author: mendyEdri

generatedTypes/src/components/dialog/index.d.ts

@@ -1,6 +1,7 @@
 import React from 'react';
 import { StyleProp, ViewStyle, ModalPropsIOS, AccessibilityProps } from 'react-native';
 import { AlignmentModifiers } from '../../commons/modifiers';
+import { ModalProps } from '../modal';
 import { PanningDirections } from '../panningViews/panningProvider';
 interface RNPartialProps extends Pick<ModalPropsIOS, 'supportedOrientations'>, Pick<AccessibilityProps, 'accessibilityLabel'> {
 }
@@ -53,6 +54,10 @@ export interface DialogProps extends AlignmentModifiers, RNPartialProps {
      * The props that will be passed to the pannable header
      */
     pannableHeaderProps?: any;
+    /**
+     * Additional props for the modal.
+     */
+    modalProps?: ModalProps;
     /**
      * The Dialog`s container style
      */

src/components/dialog/index.tsx

@@ -4,7 +4,7 @@ import {StyleSheet, StyleProp, ViewStyle, ModalPropsIOS, AccessibilityProps} fro
 import {Colors} from '../../style';
 import {AlignmentModifiers, extractAlignmentsValues} from '../../commons/modifiers';
 import {Constants, asBaseComponent} from '../../commons/new';
-import Modal from '../modal';
+import Modal, {ModalProps} from '../modal';
 import View from '../view';
 import PanListenerView from '../panningViews/panListenerView';
 import DialogDismissibleView from './DialogDismissibleView';
@@ -70,6 +70,10 @@ export interface DialogProps extends AlignmentModifiers, RNPartialProps {
    * The props that will be passed to the pannable header
    */
   pannableHeaderProps?: any;
+  /** 
+   * Additional props for the modal. 
+   */
+  modalProps?: ModalProps;
   /**
    * The Dialog`s container style
    */
@@ -246,7 +250,7 @@ class Dialog extends Component<DialogProps, DialogState> {
 
   render = () => {
     const {modalVisibility} = this.state;
-    const {testID, supportedOrientations, accessibilityLabel, ignoreBackgroundPress} = this.props;
+    const {testID, supportedOrientations, accessibilityLabel, ignoreBackgroundPress, modalProps} = this.props;
     const onBackgroundPress = !ignoreBackgroundPress ? this.hideDialogView : undefined;
 
     return (
@@ -259,6 +263,7 @@ class Dialog extends Component<DialogProps, DialogState> {
         onRequestClose={onBackgroundPress}
         supportedOrientations={supportedOrientations}
         accessibilityLabel={accessibilityLabel}
+        {...modalProps}
       >
         {this.renderDialogContainer()}
       </Modal>