Support passing dark threshold for Colors.isDark (#2505)

ethanshar · web-flow · commit 5f26ba27eeb5 · 2023-02-28T08:47:12.000+02:00
diff --git a/src/style/colors.ts b/src/style/colors.ts
@@ -273,10 +273,10 @@ export class Colors {
     return _.inRange(hue, 51, 184);
   }
 
-  isDark(colorValue: string | OpaqueColorValue) {
+  isDark(colorValue: string | OpaqueColorValue, darkThreshold = 0.55) {
     const color = colorValue === null ? undefined : colorStringValue(colorValue);
     const lum = tinycolor(color).getLuminance();
-    return lum < 0.55;
+    return lum < darkThreshold;
   }
   isValidHex(string: string) {
     return /(^#[0-9A-F]{6}$)|(^#[0-9A-F]{3}$)/i.test(string);

Original file line number	Diff line number	Diff line change
`@@ -273,10 +273,10 @@ export class Colors {`
`273`	`273`	`return _.inRange(hue, 51, 184);`
`274`	`274`	`}`
`275`	`275`
`276`		`- isDark(colorValue: string \| OpaqueColorValue) {`
	`276`	`+ isDark(colorValue: string \| OpaqueColorValue, darkThreshold = 0.55) {`
`277`	`277`	`const color = colorValue === null ? undefined : colorStringValue(colorValue);`
`278`	`278`	`const lum = tinycolor(color).getLuminance();`
`279`		`- return lum < 0.55;`
	`279`	`+ return lum < darkThreshold;`
`280`	`280`	`}`
`281`	`281`	`isValidHex(string: string) {`
`282`	`282`	`return /(^#[0-9A-F]{6}$)\|(^#[0-9A-F]{3}$)/i.test(string);`