Skip to content

Commit 6355505

Browse files
author
Ihor Morenets
authored
TS/fix carousel-related typing errors (#856)
* Fix missing pageControlPositions * Fix PageControl missing prop and not extendint intrinsic props * Update limitShownPages
1 parent fd2083a commit 6355505

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

typings/components/Carousel.d.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
import {
32
NativeScrollEvent,
43
NativeSyntheticEvent,
@@ -9,7 +8,12 @@ import {
98
import {BaseComponent} from '../commons';
109
import {PageControlProps} from './PageControl';
1110

12-
export type CarouselPageControlPosition = 'over' | 'under';
11+
type CarouselPageControlPositions = {
12+
OVER: 'over';
13+
UNDER: 'under';
14+
}
15+
16+
export type CarouselPageControlPosition = CarouselPageControlPositions[keyof CarouselPageControlPositions];
1317

1418
export interface CarouselProps {
1519
initialPage?: number;
@@ -36,4 +40,5 @@ export interface CarouselProps {
3640

3741
export class Carousel extends BaseComponent<CarouselProps> {
3842
goToPage: (pageIndex: number) => void;
43+
static pageControlPositions: CarouselPageControlPositions;
3944
}

typings/components/PageControl.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ import {GestureResponderEvent, StyleProp, ViewStyle} from 'react-native';
33
import {BaseComponent} from '../commons';
44
import {ColorValue} from '../style/colors';
55

6-
export interface PageControlProps {
6+
export interface PageControlProps extends JSX.IntrinsicAttributes {
7+
limitShownPages?: boolean;
78
containerStyle?: StyleProp<ViewStyle>;
89
numOfPages?: number;
910
currentPage?: number;

0 commit comments

Comments
 (0)