Skip to content

Commit 85157b1

Browse files
authored
Start deprecation of Picker useNativePicker prop (#2330)
1 parent 9c88bb5 commit 85157b1

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

demo/src/screens/componentScreens/PickerScreen.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ export default class PickerScreen extends Component {
126126
<Picker
127127
title="Wheel Picker"
128128
placeholder="Pick a Language"
129-
// useNativePicker
130-
useWheelPicker
129+
useNativePicker
130+
// useWheelPicker
131131
value={this.state.nativePickerValue}
132132
onChange={nativePickerValue => this.setState({nativePickerValue})}
133133
rightIconSource={dropdown}

src/components/picker/helpers/usePickerMigrationWarnings.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import _ from 'lodash';
33
import {LogService} from '../../../services';
44
import {PickerProps, PickerModes} from '../types';
55

6-
type UsePickerMigrationWarnings = Pick<PickerProps, 'value' | 'mode'>;
6+
type UsePickerMigrationWarnings = Pick<PickerProps, 'value' | 'mode' | 'useNativePicker'>;
77

88
const usePickerMigrationWarnings = (props: UsePickerMigrationWarnings) => {
9-
const {value, mode} = props;
9+
const {value, mode, useNativePicker} = props;
1010
useEffect(() => {
1111
if (mode === PickerModes.SINGLE && Array.isArray(value)) {
1212
LogService.warn('Picker in SINGLE mode cannot accept an array for value');
@@ -18,6 +18,10 @@ const usePickerMigrationWarnings = (props: UsePickerMigrationWarnings) => {
1818
if (_.isPlainObject(value)) {
1919
LogService.warn('UILib Picker will stop supporting passing object as value in the next major version. Please use either string or a number as value');
2020
}
21+
22+
if (useNativePicker) {
23+
LogService.warn(`UILib Picker will stop supporting the 'useNativePicker' prop soon, please pass instead the 'useWheelPicker' prop and handle relevant TextField migration if required to`);
24+
}
2125
}, []);
2226
};
2327

src/components/picker/types.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ export type PickerBaseProps = Omit<TextFieldProps, 'value' | 'onChange'> &
147147
*/
148148
renderCustomSearch?: (props: PickerItemsListProps) => React.ReactElement;
149149
/**
150+
* @deprecated pass useWheelPicker prop instead
150151
* Allow to use the native picker solution (different style for iOS and Android)
151152
*/
152153
useNativePicker?: boolean;

0 commit comments

Comments
 (0)