Skip to content

Commit 873b6d5

Browse files
authored
Fixed issue when TextField with validate as 'required' without placeholder renders placeholder as 'undefined *' (#830)
1 parent 2af957d commit 873b6d5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/components/inputs/BaseInput.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,9 @@ export default class BaseInput extends BaseComponent {
205205

206206
getRequiredPlaceholder(placeholder) {
207207
const {markRequired} = this.getThemeProps();
208-
if (this.isRequiredField() && markRequired) {
208+
const shouldDisplayPlaceholderAsRequired = (this.isRequiredField() && markRequired && placeholder);
209+
210+
if (shouldDisplayPlaceholderAsRequired) {
209211
return `${placeholder} *`;
210212
}
211213
return placeholder;

0 commit comments

Comments
 (0)