Checkbox - validate to return validity (#3672)

* Fix validation logic in Checkbox component to return error state

* Added tests to cover validate return value

* Better readability to validate function

Author: nitzanyiz

src/components/checkbox/__tests__/index.spec.tsx

@@ -158,6 +158,19 @@ describe('Checkbox renderer test', () => {
 
         expect(onChangeValidity).toHaveBeenCalledWith(false);
       });
+
+      it.each([false, true])('should return validity from validate function - initial %s', async (initialValue) => {
+        const props: CheckboxProps = {required: true, onChangeValidity, value: initialValue};
+        const renderTree = render(<TestCase {...props}/>);
+        const driver = CheckboxDriver({renderTree, testID});
+
+        expect(checkboxRef.current?.validate()).toBe(initialValue);
+
+        await driver.press();
+
+        expect(checkboxRef.current?.validate()).toBe(!initialValue);
+
+      });
     });
 
     describe('isValid', () => {

src/components/checkbox/index.tsx

@@ -306,9 +306,10 @@ class Checkbox extends Component<CheckboxProps, CheckboxState> {
 
   validate = () => {
     const {value, required} = this.props;
-    const error = required && !value;
-    this.validationState = true; 
-    this.setState({showError: error, isValid: !error});
+    const isValid = !(required && !value);
+    this.validationState = true;
+    this.setState({showError: !isValid, isValid});
+    return isValid;
   };
 
   isValid = () => {