Skip to content

Commit 953d13d

Browse files
committed
Fix/react native svg cssuri path (#3394)
* fixed optional dep CssUri * make it more readable * changed the way cssuri is exported so it won't trigger the error * updated react-native-svg version to ^15.2.0 * updated react-native-svg version to 15.2.0 (exact)
1 parent 08c2a81 commit 953d13d

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
"react-native-navigation": "7.40.1",
121121
"react-native-reanimated": "3.8.1",
122122
"react-native-shimmer-placeholder": "^2.0.6",
123-
"react-native-svg": "^13.7.0",
123+
"react-native-svg": "15.2.0",
124124
"react-native-svg-transformer": "1.5.0",
125125
"react-test-renderer": "18.2.0",
126126
"reassure": "^0.4.1",

src/components/svgImage/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import React from 'react';
22
import {isSvg, isSvgUri} from '../../utils/imageUtils';
3-
import {SvgPackage} from '../../optionalDependencies';
3+
import {SvgPackage, SvgCssUri} from '../../optionalDependencies';
44

55
const SvgXml = SvgPackage?.SvgXml;
6-
const SvgCssUri = SvgPackage?.SvgCssUri;
76
// const SvgProps = SvgPackage?.SvgProps; TODO: not sure how (or if) we can use their props
87

98
export interface SvgImageProps {
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
let SvgPackage: any;
2+
let svgCssForPackage14Higher: any;
23
try {
34
SvgPackage = require('react-native-svg');
5+
svgCssForPackage14Higher = require('react-native-svg/css');
46
// Sadly we cannot verify with require('react-native-svg-transformer');
57
} catch (error) {}
68

9+
export const SvgCssUri = svgCssForPackage14Higher?.SvgCssUri ?? SvgPackage?.SvgCssUri;
710
export default SvgPackage;

src/optionalDependencies/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ export {default as BlurViewPackage} from './BlurViewPackage';
44
export {default as MomentPackage} from './MomentPackage';
55
export {default as NetInfoPackage} from './NetInfoPackage';
66
export {default as HapticFeedbackPackage} from './HapticFeedbackPackage';
7-
export {default as SvgPackage} from './SvgPackage';
7+
export {default as SvgPackage, SvgCssUri} from './SvgPackage';
88
export {createShimmerPlaceholder} from './ShimmerPackage';
99
export {default as LinearGradientPackage} from './LinearGradientPackage';

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10269,16 +10269,16 @@ __metadata:
1026910269
languageName: node
1027010270
linkType: hard
1027110271

10272-
"react-native-svg@npm:^13.7.0":
10273-
version: 13.14.1
10274-
resolution: "react-native-svg@npm:13.14.1"
10272+
"react-native-svg@npm:15.2.0":
10273+
version: 15.2.0
10274+
resolution: "react-native-svg@npm:15.2.0"
1027510275
dependencies:
1027610276
css-select: ^5.1.0
1027710277
css-tree: ^1.1.3
1027810278
peerDependencies:
1027910279
react: "*"
1028010280
react-native: "*"
10281-
checksum: 273f05f2cceabf09f3909f57108d10f56aeb38981146e5f7b72cdb8595fbfb524af891845d4240a629c2f91ed120ae603d9efd579f7fb88521769aec71811136
10281+
checksum: 0075d3c5bcf6bbbebe064364ec72c02eeff3fc0f2b1ba127bde26a8ecedc190a7890a910a6a051687318fa80504a3bc335eee2bfd6846b90193ca1608bae821e
1028210282
languageName: node
1028310283
linkType: hard
1028410284

@@ -10359,7 +10359,7 @@ __metadata:
1035910359
react-native-reanimated: 3.8.1
1036010360
react-native-redash: ^12.0.3
1036110361
react-native-shimmer-placeholder: ^2.0.6
10362-
react-native-svg: ^13.7.0
10362+
react-native-svg: 15.2.0
1036310363
react-native-svg-transformer: 1.5.0
1036410364
react-test-renderer: 18.2.0
1036510365
reassure: ^0.4.1

0 commit comments

Comments
 (0)