Skip to content

Commit 9d8b588

Browse files
committed
Add supportedOrientations and accessibilityLabel
1 parent 2f2b17c commit 9d8b588

File tree

4 files changed

+24
-4
lines changed

4 files changed

+24
-4
lines changed

demo/src/screens/incubatorScreens/IncubatorDialogScreen.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, {Component} from 'react';
2-
import {StyleSheet} from 'react-native';
2+
import {StyleSheet, ModalProps} from 'react-native';
33
import {FlatList} from 'react-native-gesture-handler';
44
import {View, Text, Card, Button, Incubator, Colors, BorderRadiuses} from 'react-native-ui-lib'; //eslint-disable-line
55

@@ -33,6 +33,7 @@ const colors: Item[] = [
3333

3434
export default class IncubatorDialogScreen extends Component {
3535
state = {visible: false};
36+
supportedOrientations: ModalProps['supportedOrientations'] = ['portrait', 'landscape'];
3637

3738
renderVerticalItem = ({item}: {item: Item}) => {
3839
return (
@@ -69,7 +70,14 @@ export default class IncubatorDialogScreen extends Component {
6970
<View flex center>
7071
<Button marginV-20 label="Open Dialog" onPress={this.openDialog}/>
7172
</View>
72-
<Incubator.Dialog useSafeArea visible={visible} onDismiss={this.onDismiss} bottom centerH>
73+
<Incubator.Dialog
74+
useSafeArea
75+
visible={visible}
76+
onDismiss={this.onDismiss}
77+
bottom
78+
centerH
79+
supportedOrientations={this.supportedOrientations}
80+
>
7381
<View style={styles.dialog}>
7482
<Text text60 margin-s2>
7583
Title (swipe here)

generatedTypes/src/incubator/Dialog/types.d.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
import { PropsWithChildren } from 'react';
2+
import { ModalPropsIOS, AccessibilityProps } from 'react-native';
23
import { AlignmentModifiers } from '../../commons/modifiers';
34
import { ModalProps } from '../../components/modal';
45
import { ViewProps } from '../../components/view';
56
import { PanningDirections, PanningDirectionsEnum } from '../panView';
67
declare type DialogDirections = PanningDirections;
78
declare const DialogDirectionsEnum: typeof PanningDirectionsEnum;
89
export { DialogDirections, DialogDirectionsEnum };
9-
export interface _DialogProps extends AlignmentModifiers, Pick<ViewProps, 'useSafeArea'> {
10+
interface RNPartialProps extends Pick<ModalPropsIOS, 'supportedOrientations'>, Pick<AccessibilityProps, 'accessibilityLabel'> {
11+
}
12+
export interface _DialogProps extends RNPartialProps, AlignmentModifiers, Pick<ViewProps, 'useSafeArea'> {
1013
/**
1114
* The initial visibility of the dialog.
1215
*/

src/incubator/Dialog/ImperativeDialog.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ const ImperativeDialog = (props: ImperativeDialogProps, ref: any) => {
1818
ignoreBackgroundPress,
1919
modalProps = {},
2020
useSafeArea,
21+
supportedOrientations,
22+
accessibilityLabel,
2123
testID
2224
} = props;
2325
const transitionAnimatorRef = React.createRef<typeof TransitionView>();
@@ -103,6 +105,8 @@ const ImperativeDialog = (props: ImperativeDialogProps, ref: any) => {
103105
onBackgroundPress={ignoreBackgroundPress ? undefined : onBackgroundPress}
104106
onRequestClose={ignoreBackgroundPress ? undefined : onBackgroundPress}
105107
onDismiss={undefined}
108+
supportedOrientations={supportedOrientations}
109+
accessibilityLabel={accessibilityLabel}
106110
>
107111
{FadeView}
108112
<View pointerEvents={'box-none'} style={alignmentStyle}>

src/incubator/Dialog/types.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {PropsWithChildren} from 'react';
2+
import {ModalPropsIOS, AccessibilityProps} from 'react-native';
23
import {AlignmentModifiers} from '../../commons/modifiers';
34
import {ModalProps} from '../../components/modal';
45
import {ViewProps} from '../../components/view';
@@ -7,7 +8,11 @@ type DialogDirections = PanningDirections;
78
const DialogDirectionsEnum = PanningDirectionsEnum;
89
export {DialogDirections, DialogDirectionsEnum};
910

10-
export interface _DialogProps extends AlignmentModifiers, Pick<ViewProps, 'useSafeArea'> {
11+
interface RNPartialProps
12+
extends Pick<ModalPropsIOS, 'supportedOrientations'>,
13+
Pick<AccessibilityProps, 'accessibilityLabel'> {}
14+
15+
export interface _DialogProps extends RNPartialProps, AlignmentModifiers, Pick<ViewProps, 'useSafeArea'> {
1116
/**
1217
* The initial visibility of the dialog.
1318
*/

0 commit comments

Comments
 (0)