Picker multi select support - test fixed (#885)

* pass dialog events to picker custom model to support multi-selection

* refactor code to make label text decision more intuitive

* Made label source selection more intuitive

* changed test uut function to match new logic -[failed tests]

* fixed eslint issue

Co-authored-by: Ethan Sharabi <[email protected]>

Author: mendyEdri

src/components/picker/__tests__/index.spec.js

@@ -12,14 +12,14 @@ describe('Picker', () => {
   describe('getLabel', () => {
     it('should get label of a simple item', () => {
       let uut = new Picker({value: countries[2]});
-      expect(uut.getLabel()).toEqual(countries[2].label);
+      expect(uut.getLabelValueText()).toEqual(countries[2].label);
       uut = new Picker({value: countries[3]});
-      expect(uut.getLabel()).toEqual(countries[3].label);
+      expect(uut.getLabelValueText()).toEqual(countries[3].label);
     });
 
     it('should get label out of an array of items', () => {
       const uut = new Picker({value: [countries[2], countries[4]]});
-      expect(uut.getLabel()).toEqual(`${countries[2].label}, ${countries[4].label}`);
+      expect(uut.getLabelValueText()).toEqual(`${countries[2].label}, ${countries[4].label}`);
     });
   });
 

src/components/picker/index.js

@@ -169,8 +169,8 @@ class Picker extends BaseComponent {
   getAccessibilityInfo() {
     const {placeholder} = this.props;
     return {
-      accessibilityLabel: this.getLabel() ? `${placeholder}. selected. ${this.getLabel()}` : `Select ${placeholder}`,
-      accessibilityHint: this.getLabel()
+      accessibilityLabel: this.getLabelValueText() ? `${placeholder}. selected. ${this.getLabelValueText()}` : `Select ${placeholder}`,
+      accessibilityHint: this.getLabelValueText()
         ? 'Double tap to edit'
         : `Goes to ${placeholder}. Suggestions will be provided`,
       ...this.extractAccessibilityProps()
@@ -224,7 +224,7 @@ class Picker extends BaseComponent {
     const {items} = this.state;
     const selectedItem = _.find(items, {value});
     return _.get(selectedItem, 'label');
-  };
+  }
 
   handlePickerOnPress = () => {
     this.toggleExpandableModal(true);