Skip to content

Commit cc80598

Browse files
nitzanyiznitzanyiz
authored
TextField - Increase hitslop (#3504)
* Increased hitslop by 20 to top and bottom
1 parent 3b8c072 commit cc80598

File tree

2 files changed

+127
-0
lines changed

2 files changed

+127
-0
lines changed

‎demo/src/screens/__tests__/__snapshots__/TextFieldScreen.spec.js.snap

Lines changed: 126 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,12 @@ exports[`TextField Screen renders screen 1`] = `
177177
}
178178
}
179179
editable={true}
180+
hitSlop={
181+
{
182+
"bottom": 20,
183+
"top": 20,
184+
}
185+
}
180186
onBlur={[Function]}
181187
onChangeText={[Function]}
182188
onFocus={[Function]}
@@ -632,6 +638,12 @@ exports[`TextField Screen renders screen 1`] = `
632638
}
633639
}
634640
editable={true}
641+
hitSlop={
642+
{
643+
"bottom": 20,
644+
"top": 20,
645+
}
646+
}
635647
onBlur={[Function]}
636648
onChangeText={[Function]}
637649
onFocus={[Function]}
@@ -1166,6 +1178,12 @@ exports[`TextField Screen renders screen 1`] = `
11661178
}
11671179
}
11681180
editable={false}
1181+
hitSlop={
1182+
{
1183+
"bottom": 20,
1184+
"top": 20,
1185+
}
1186+
}
11691187
onBlur={[Function]}
11701188
onChangeText={[Function]}
11711189
onFocus={[Function]}
@@ -1527,6 +1545,12 @@ exports[`TextField Screen renders screen 1`] = `
15271545
}
15281546
}
15291547
editable={true}
1548+
hitSlop={
1549+
{
1550+
"bottom": 20,
1551+
"top": 20,
1552+
}
1553+
}
15301554
onBlur={[Function]}
15311555
onChangeText={[Function]}
15321556
onFocus={[Function]}
@@ -1752,6 +1776,12 @@ exports[`TextField Screen renders screen 1`] = `
17521776
}
17531777
}
17541778
editable={true}
1779+
hitSlop={
1780+
{
1781+
"bottom": 20,
1782+
"top": 20,
1783+
}
1784+
}
17551785
onBlur={[Function]}
17561786
onChangeText={[Function]}
17571787
onFocus={[Function]}
@@ -2111,6 +2141,12 @@ exports[`TextField Screen renders screen 1`] = `
21112141
}
21122142
}
21132143
editable={true}
2144+
hitSlop={
2145+
{
2146+
"bottom": 20,
2147+
"top": 20,
2148+
}
2149+
}
21142150
onBlur={[Function]}
21152151
onChangeText={[Function]}
21162152
onFocus={[Function]}
@@ -2420,6 +2456,12 @@ exports[`TextField Screen renders screen 1`] = `
24202456
}
24212457
}
24222458
editable={true}
2459+
hitSlop={
2460+
{
2461+
"bottom": 20,
2462+
"top": 20,
2463+
}
2464+
}
24232465
onBlur={[Function]}
24242466
onChangeText={[Function]}
24252467
onFocus={[Function]}
@@ -2979,6 +3021,12 @@ exports[`TextField Screen renders screen 1`] = `
29793021
}
29803022
}
29813023
editable={true}
3024+
hitSlop={
3025+
{
3026+
"bottom": 20,
3027+
"top": 20,
3028+
}
3029+
}
29823030
onBlur={[Function]}
29833031
onChangeText={[Function]}
29843032
onChangeValidity={[Function]}
@@ -3317,6 +3365,12 @@ exports[`TextField Screen renders screen 1`] = `
33173365
}
33183366
}
33193367
editable={true}
3368+
hitSlop={
3369+
{
3370+
"bottom": 20,
3371+
"top": 20,
3372+
}
3373+
}
33203374
maxLength={20}
33213375
onBlur={[Function]}
33223376
onChangeText={[Function]}
@@ -3739,6 +3793,12 @@ exports[`TextField Screen renders screen 1`] = `
37393793
}
37403794
}
37413795
editable={true}
3796+
hitSlop={
3797+
{
3798+
"bottom": 20,
3799+
"top": 20,
3800+
}
3801+
}
37423802
onBlur={[Function]}
37433803
onChangeText={[Function]}
37443804
onFocus={[Function]}
@@ -4161,6 +4221,12 @@ exports[`TextField Screen renders screen 1`] = `
41614221
}
41624222
}
41634223
editable={true}
4224+
hitSlop={
4225+
{
4226+
"bottom": 20,
4227+
"top": 20,
4228+
}
4229+
}
41644230
maxLength={20}
41654231
multiline={true}
41664232
onBlur={[Function]}
@@ -4484,6 +4550,12 @@ exports[`TextField Screen renders screen 1`] = `
44844550
}
44854551
}
44864552
editable={true}
4553+
hitSlop={
4554+
{
4555+
"bottom": 20,
4556+
"top": 20,
4557+
}
4558+
}
44874559
onBlur={[Function]}
44884560
onChangeText={[Function]}
44894561
onFocus={[Function]}
@@ -4776,6 +4848,12 @@ exports[`TextField Screen renders screen 1`] = `
47764848
}
47774849
}
47784850
editable={true}
4851+
hitSlop={
4852+
{
4853+
"bottom": 20,
4854+
"top": 20,
4855+
}
4856+
}
47794857
keyboardType="numeric"
47804858
onBlur={[Function]}
47814859
onChangeText={[Function]}
@@ -5092,6 +5170,12 @@ exports[`TextField Screen renders screen 1`] = `
50925170
}
50935171
}
50945172
editable={true}
5173+
hitSlop={
5174+
{
5175+
"bottom": 20,
5176+
"top": 20,
5177+
}
5178+
}
50955179
onBlur={[Function]}
50965180
onChangeText={[Function]}
50975181
onFocus={[Function]}
@@ -5825,6 +5909,12 @@ exports[`TextField Screen renders screen 1`] = `
58255909
}
58265910
}
58275911
editable={true}
5912+
hitSlop={
5913+
{
5914+
"bottom": 20,
5915+
"top": 20,
5916+
}
5917+
}
58285918
onBlur={[Function]}
58295919
onChangeText={[Function]}
58305920
onFocus={[Function]}
@@ -6119,6 +6209,12 @@ exports[`TextField Screen renders screen 1`] = `
61196209
}
61206210
}
61216211
editable={true}
6212+
hitSlop={
6213+
{
6214+
"bottom": 20,
6215+
"top": 20,
6216+
}
6217+
}
61226218
onBlur={[Function]}
61236219
onChangeText={[Function]}
61246220
onFocus={[Function]}
@@ -6442,6 +6538,12 @@ exports[`TextField Screen renders screen 1`] = `
64426538
}
64436539
}
64446540
editable={true}
6541+
hitSlop={
6542+
{
6543+
"bottom": 20,
6544+
"top": 20,
6545+
}
6546+
}
64456547
onBlur={[Function]}
64466548
onChangeText={[Function]}
64476549
onFocus={[Function]}
@@ -6811,6 +6913,12 @@ exports[`TextField Screen renders screen 1`] = `
68116913
}
68126914
}
68136915
editable={true}
6916+
hitSlop={
6917+
{
6918+
"bottom": 20,
6919+
"top": 20,
6920+
}
6921+
}
68146922
onBlur={[Function]}
68156923
onChangeText={[Function]}
68166924
onFocus={[Function]}
@@ -7085,6 +7193,12 @@ exports[`TextField Screen renders screen 1`] = `
70857193
}
70867194
}
70877195
editable={true}
7196+
hitSlop={
7197+
{
7198+
"bottom": 20,
7199+
"top": 20,
7200+
}
7201+
}
70887202
onBlur={[Function]}
70897203
onChangeText={[Function]}
70907204
onFocus={[Function]}
@@ -7334,6 +7448,12 @@ exports[`TextField Screen renders screen 1`] = `
73347448
}
73357449
}
73367450
editable={true}
7451+
hitSlop={
7452+
{
7453+
"bottom": 20,
7454+
"top": 20,
7455+
}
7456+
}
73377457
onBlur={[Function]}
73387458
onChangeText={[Function]}
73397459
onFocus={[Function]}
@@ -7599,6 +7719,12 @@ exports[`TextField Screen renders screen 1`] = `
75997719
}
76007720
}
76017721
editable={true}
7722+
hitSlop={
7723+
{
7724+
"bottom": 20,
7725+
"top": 20,
7726+
}
7727+
}
76027728
onBlur={[Function]}
76037729
onChangeText={[Function]}
76047730
onFocus={[Function]}

‎src/components/textField/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ const TextField = (props: InternalTextFieldProps) => {
194194
/>
195195
)}
196196
<Input
197+
hitSlop={{top: 20, bottom: 20}}
197198
placeholderTextColor={hidePlaceholder ? 'transparent' : placeholderTextColor}
198199
value={fieldState.value}
199200
{...others}

0 commit comments

Comments
 (0)