Revert "Dialog - RN63 broke Modal's onDismiss method, this fixes our API (#1026)"

This reverts commit 7ee9fc1.

Author: ethanshar

generatedTypes/components/dialog/OverlayFadingBackground.d.ts

@@ -4,10 +4,9 @@ interface Props {
     dialogVisibility?: boolean;
     modalVisibility?: boolean;
     overlayBackgroundColor?: string;
-    onFadeDone?: () => void;
 }
 declare const OverlayFadingBackground: {
-    ({ testID, dialogVisibility, modalVisibility, overlayBackgroundColor, onFadeDone }: Props): JSX.Element;
+    ({ testID, dialogVisibility, modalVisibility, overlayBackgroundColor }: Props): JSX.Element;
     displayName: string;
 };
 export default OverlayFadingBackground;

src/components/dialog/OverlayFadingBackground.tsx

@@ -7,15 +7,13 @@ interface Props {
   dialogVisibility?: boolean;
   modalVisibility?: boolean;
   overlayBackgroundColor?: string;
-  onFadeDone?: () => void;
 }
 
 const OverlayFadingBackground = ({
   testID,
   dialogVisibility,
   modalVisibility,
-  overlayBackgroundColor,
-  onFadeDone
+  overlayBackgroundColor
 }: Props) => {
   const fadeAnimation = useRef(new Animated.Value(0)).current;
 
@@ -24,8 +22,8 @@ const OverlayFadingBackground = ({
       toValue,
       duration: 400,
       useNativeDriver: true
-    }).start(onFadeDone);
-  }, [fadeAnimation, onFadeDone]);
+    }).start();
+  }, [fadeAnimation]);
 
   useEffect(() => {
     if (!dialogVisibility) {

src/components/dialog/index.tsx

@@ -161,16 +161,6 @@ class Dialog extends Component<DialogProps, DialogState> {
     }
   }
 
-  // TODO: revert adding this workaround once RN fixes https://github.com/facebook/react-native/issues/29455
-  onFadeDone = () => {
-    if (!this.state.modalVisibility) {
-      setTimeout(() => { // unfortunately this is needed if a modal needs to open on iOS
-        _.invoke(this.props, 'onDialogDismissed', this.props);
-        _.invoke(this.props, 'onModalDismissed', this.props);
-      }, 50);
-    }
-  }
-
   onDismiss = () => {
     this.setState({modalVisibility: false}, () => {
       const props = this.props;
@@ -231,7 +221,6 @@ class Dialog extends Component<DialogProps, DialogState> {
     const {useSafeArea, bottom, overlayBackgroundColor, testID} = this.props;
     const addBottomSafeArea = Constants.isIphoneX && (useSafeArea && bottom);
     const bottomInsets = Constants.getSafeAreaInsets().bottom - 8; // TODO: should this be here or in the input style?
-    const onFadeDone = Constants.isIOS ? this.onFadeDone : undefined;
 
     return (
       <View
@@ -244,7 +233,6 @@ class Dialog extends Component<DialogProps, DialogState> {
           modalVisibility={modalVisibility}
           dialogVisibility={dialogVisibility}
           overlayBackgroundColor={overlayBackgroundColor}
-          onFadeDone={onFadeDone}
         />
         {this.renderDialogView()}
         {addBottomSafeArea && <View style={{marginTop: bottomInsets}}/>}
@@ -265,7 +253,7 @@ class Dialog extends Component<DialogProps, DialogState> {
         animationType={'none'}
         onBackgroundPress={this.hideDialogView}
         onRequestClose={this.hideDialogView}
-        // onDismiss={this.onModalDismissed}
+        onDismiss={this.onModalDismissed}
         supportedOrientations={supportedOrientations}
         accessibilityLabel={accessibilityLabel}
       >