Fix/eslint findValueNodeOfIdentifier util (#1268)

* Fix/findValueNodeOfIdentifier util

* update eslint-plugin-uilib version

Author: lidord-wix

eslint-rules/lib/utils/generalUtils.js

@@ -1,3 +1,5 @@
+const _ = require('lodash');
+
 function getPrefix(str) {
   const indexOfDot = str.indexOf('.');
   return indexOfDot === -1 ? str : str.substring(0, indexOfDot);
@@ -18,6 +20,16 @@ function findValueNodeOfIdentifier(identifierName, scope) {
       }
     }
   });
+  if (valueNode === null || valueNode.value !== undefined) {
+    scope.block.body.forEach(scopeNode => {
+      if (scopeNode.type === 'ExpressionStatement') {
+        const variableName = _.get(scopeNode, 'expression.left.name');
+        if (variableName === identifierName) {
+          valueNode = scopeNode.expression.right;
+        }
+      }
+    });
+  }
   if (scope.upper === null) {
     return valueNode;
   }

eslint-rules/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-uilib",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "uilib set of eslint rules",
   "keywords": [
     "eslint",

eslint-rules/tests/lib/rules/no-hard-coded-color.js

@@ -38,9 +38,7 @@ const validStyleSheetExample = `StyleSheet.create({
 })
 `;
 
-const invalidConditionalExpression = `const test = <Text style = {{ color: true ? '${Colors.dark10}' : '${
-  Colors.dark20
-}'}}> </Text>;`;
+const invalidConditionalExpression = `const test = <Text style = {{ color: true ? '${Colors.dark10}' : '${Colors.dark20}'}}> </Text>;`;
 const validConditionalExpression =
   'const test = <Text style = {{ color: true ? Colors.dark10 : Colors.dark20}}> </Text>;';
 
@@ -60,6 +58,40 @@ ruleTester.run('no-hard-coded-color', rule, {
     {code: 'const goodUsage = <View style={{backgroundColor: Constants.blue20}}/>;'}
   ],
   invalid: [
+    {
+      options: ruleOptions,
+      code: `
+      let x;
+      let y;
+      x = '#20303C';
+      y = 3;
+      const test = <Text style={{color: x}}>text</Text>;
+      `,
+      output: `
+      let x;
+      let y;
+      x = Colors.dark10;
+      y = 3;
+      const test = <Text style={{color: x}}>text</Text>;
+      `,
+      errors: [{message: "Found '#20303C'. Use UILib colors instead of hardcoded colors."}]
+    },
+    {
+      options: ruleOptions,
+      code: `
+      let x = 0;
+      x = 1;
+      x = '#20303C';
+      const test = <Text style={{color: x}}>text</Text>;
+      `,
+      output: `
+      let x = 0;
+      x = 1;
+      x = Colors.dark10;
+      const test = <Text style={{color: x}}>text</Text>;
+      `,
+      errors: [{message: "Found '#20303C'. Use UILib colors instead of hardcoded colors."}]
+    },
     {
       options: ruleOptions,
       code: invalidStyleSheetExample,