Skip to content

Commit d63f0e9

Browse files
authored
Picker - fix not responding to external value change when renderPicker is used (#1211)
* Picker - fix not responding to external value change when renderPicker is used * Add prevValue to the state update
1 parent eccce40 commit d63f0e9

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

generatedTypes/index.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ export {
9999
WheelPickerProps,
100100
ColorPicker,
101101
Picker,
102+
PickerItemValue,
102103
PickerProps
103104
} from '../typings';
104105

src/components/picker/index.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,11 @@ class Picker extends Component {
186186
value: nextProps.value
187187
};
188188
}
189+
} else if (_.isFunction(nextProps.renderPicker) && prevState.value !== nextProps.value) {
190+
return {
191+
prevValue: prevState.value,
192+
value: nextProps.value
193+
};
189194
}
190195
return null;
191196
}

0 commit comments

Comments
 (0)