Skip to content

Commit d72e9c9

Browse files
authored
PanningProviderDirection - removing type (use PanningDirections) (#1542)
1 parent bccb5d9 commit d72e9c9

File tree

8 files changed

+13
-25
lines changed

8 files changed

+13
-25
lines changed

generatedTypes/index.d.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ export {
7171
PanningDirections,
7272
PanLocationProps,
7373
PanAmountsProps,
74-
PanDirectionsProps,
75-
PanningProviderDirection
74+
PanDirectionsProps
7675
} from './src/components/panningViews/panningProvider';
7776
export {default as PanListenerView, PanListenerViewProps} from './src/components/panningViews/panListenerView';
7877
export {default as PanResponderView, PanResponderViewProps} from './src/components/panningViews/panResponderView';

generatedTypes/src/components/panningViews/panDismissibleView.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import { StyleProp, ViewStyle } from 'react-native';
3-
import { PanningDirections, PanningProviderDirection, PanAmountsProps } from './panningProvider';
3+
import { PanningDirections, PanAmountsProps } from './panningProvider';
44
export interface DismissibleAnimationProps {
55
/**
66
* The return animation speed (default is 20)
@@ -24,7 +24,7 @@ export interface PanDismissibleViewProps {
2424
* The directions of the allowed pan (default allows all directions)
2525
* Types: UP, DOWN, LEFT and RIGHT (using PanningProvider.Directions.###)
2626
*/
27-
directions?: PanningDirections[] | PanningProviderDirection[];
27+
directions?: PanningDirections[];
2828
/**
2929
* onDismiss callback
3030
*/

generatedTypes/src/components/panningViews/panListenerView.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import { PanningDirections, PanDirectionsProps, PanAmountsProps, PanningProviderDirection } from './panningProvider';
2+
import { PanningDirections, PanDirectionsProps, PanAmountsProps } from './panningProvider';
33
import { ViewProps } from '../view';
44
interface PanningProps {
55
/**
@@ -46,7 +46,7 @@ export interface PanListenerViewProps extends PanningProps, ViewProps {
4646
* The directions of the allowed pan (default allows all directions)
4747
* Types: UP, DOWN, LEFT and RIGHT (using PanningProvider.Directions.###)
4848
*/
49-
directions?: PanningDirections[] | PanningProviderDirection[];
49+
directions?: PanningDirections[];
5050
/**
5151
* The sensitivity beyond which a pan is no longer considered a single click (default is 5)
5252
*/

generatedTypes/src/components/panningViews/panningProvider.d.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
import { Component } from 'react';
2-
/**
3-
* @deprecated Please transition to PanningDirections
4-
*/
5-
export declare type PanningProviderDirection = 'up' | 'down' | 'left' | 'right';
62
export declare enum PanningDirections {
73
UP = "up",
84
DOWN = "down",
@@ -14,8 +10,8 @@ export interface PanLocationProps {
1410
top?: number;
1511
}
1612
export interface PanDirectionsProps {
17-
x?: PanningDirections | PanningProviderDirection;
18-
y?: PanningDirections | PanningProviderDirection;
13+
x?: PanningDirections;
14+
y?: PanningDirections;
1915
}
2016
export interface PanAmountsProps {
2117
x?: number;

src/components/panningViews/panDismissibleView.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {Constants} from '../../helpers';
55
import asPanViewConsumer from './asPanViewConsumer';
66
import PanningProvider, {
77
PanningDirections,
8-
PanningProviderDirection,
98
PanAmountsProps,
109
PanDirectionsProps
1110
} from './panningProvider';
@@ -34,7 +33,7 @@ export interface PanDismissibleViewProps {
3433
* The directions of the allowed pan (default allows all directions)
3534
* Types: UP, DOWN, LEFT and RIGHT (using PanningProvider.Directions.###)
3635
*/
37-
directions?: PanningDirections[] | PanningProviderDirection[];
36+
directions?: PanningDirections[];
3837
/**
3938
* onDismiss callback
4039
*/

src/components/panningViews/panListenerView.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ import asPanViewConsumer from './asPanViewConsumer';
1010
import PanningProvider, {
1111
PanningDirections,
1212
PanDirectionsProps,
13-
PanAmountsProps,
14-
PanningProviderDirection
13+
PanAmountsProps
1514
} from './panningProvider';
1615
import View, {ViewProps} from '../view';
1716

@@ -55,7 +54,7 @@ export interface PanListenerViewProps extends PanningProps, ViewProps {
5554
* The directions of the allowed pan (default allows all directions)
5655
* Types: UP, DOWN, LEFT and RIGHT (using PanningProvider.Directions.###)
5756
*/
58-
directions?: PanningDirections[] | PanningProviderDirection[];
57+
directions?: PanningDirections[];
5958
/**
6059
* The sensitivity beyond which a pan is no longer considered a single click (default is 5)
6160
*/

src/components/panningViews/panningProvider.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
import React, {Component} from 'react';
22
import PanningContext from './panningContext';
33

4-
/**
5-
* @deprecated Please transition to PanningDirections
6-
*/
7-
export type PanningProviderDirection = 'up' | 'down' | 'left' | 'right';
84

95
export enum PanningDirections {
106
UP = 'up',
@@ -19,8 +15,8 @@ export interface PanLocationProps {
1915
}
2016

2117
export interface PanDirectionsProps {
22-
x?: PanningDirections | PanningProviderDirection;
23-
y?: PanningDirections | PanningProviderDirection;
18+
x?: PanningDirections;
19+
y?: PanningDirections;
2420
}
2521

2622
export interface PanAmountsProps {

src/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,7 @@ export {
6767
PanningDirections,
6868
PanLocationProps,
6969
PanAmountsProps,
70-
PanDirectionsProps,
71-
PanningProviderDirection
70+
PanDirectionsProps
7271
} from './components/panningViews/panningProvider';
7372
export {default as PanListenerView, PanListenerViewProps} from './components/panningViews/panListenerView';
7473
export {default as PanResponderView, PanResponderViewProps} from './components/panningViews/panResponderView';

0 commit comments

Comments
 (0)