ESLint - add support for class or inherited functions (#1272)

Author: M-i-k-e-l

eslint-rules/lib/rules/function-deprecation.js

@@ -214,9 +214,31 @@ module.exports = {
       }
     }
 
+    // Test for forbidden inherited functions (no source)
+    function testClassBody(node) {
+      if (node && node.body) {
+        _.forEach(node.body, item => {
+          const type = _.get(item, 'type');
+          if (type === 'ClassProperty' || type === 'MethodDefinition') {
+            const deprecation = _.find(deprecations,
+              (deprecation) => !deprecation.source && deprecation.function === _.get(item, 'key.name')
+            )
+
+            if (deprecation) {
+              reportDeprecatedFunction(node, {
+                name: deprecation.function,
+                message: deprecation.message
+              });
+            }
+          }
+        });
+      }
+    }
+
     return {
       ImportDeclaration: (node) => searchForPossibleDeprecation(node),
       CallExpression: (node) => relevantDeprecationsData.length > 0 && testCallExpression(node),
+      ClassBody: (node) => testClassBody(node),
     };
   },
 };

eslint-rules/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-uilib",
-  "version": "2.0.4",
+  "version": "2.0.5",
   "description": "uilib set of eslint rules",
   "keywords": [
     "eslint",

eslint-rules/tests/function_deprecation.json

@@ -21,5 +21,9 @@
         ]
       }
     ]
+  },
+  {
+    "function": "deprecatedInheritedFunction",
+    "message": "please stop using it."
   }
 ]

eslint-rules/tests/lib/rules/function-deprecation.js

@@ -99,8 +99,48 @@ class Example extends Component {
   }
 }`;
 
+const fullClassDeprecated3 = `
+import {Something} from '${notOurSource}';
+import * as Everything from '${ourSource}';
+import {SomethingElse} from '${notOurSource2}';
+class Example extends Component {
+
+  deprecatedInheritedFunction = () => {
+    return true
+  }
+}`;
+
+const fullClassDeprecated4 = `
+import {Something} from '${notOurSource}';
+import * as Everything from '${ourSource}';
+import {SomethingElse} from '${notOurSource2}';
+class Example extends Component {
+
+  deprecatedInheritedFunction() {
+    return true
+  }
+}`;
+
+const fullClassDeprecated5 = `
+import {someFunction} from '${notOurSource}';
+class Example extends Component {
+
+  deprecatedFunction = () => {
+    someFunction(${validProps});
+  }
+
+  render() {
+    return (
+      <TouchableOpacity flex center>
+        onPress={this.deprecatedFunction}
+      </TouchableOpacity>
+    );
+  }
+}`;
+
 const functionError = "The 'deprecatedFunction' function is deprecated. Please use the 'validFunction' function instead (fix is available).";
 const propError = "The 'validFunction' function's prop 'deprecatedProp' is deprecated. Please use the 'validProp' prop instead (fix is available).";
+const classFunctionError = "The 'deprecatedInheritedFunction' function is deprecated. please stop using it.";
 const errorDate = ' Please fix this issue by 2 November, Friday!';
 
 ruleTester.run('function-deprecation', rule, {
@@ -165,6 +205,10 @@ ruleTester.run('function-deprecation', rule, {
       options: options,
       code: `${fullClassValid}`,
     },
+    {
+      options: options,
+      code: `${fullClassDeprecated5}`,
+    },
   ],
   invalid: [
     {
@@ -269,5 +313,19 @@ deprecatedFunction(getProp())`,
         { message: functionError },
       ],
     },
+    {
+      options: options,
+      code: `${fullClassDeprecated3}`,
+      errors: [
+        { message: classFunctionError }
+      ],
+    },
+    {
+      options: options,
+      code: `${fullClassDeprecated4}`,
+      errors: [
+        { message: classFunctionError }
+      ],
+    },
   ],
 });