code-review

Author: AmitShwarts

src/components/switch/switch.api.json

@@ -25,7 +25,8 @@
     {"name": "thumbSize", "type": "number", "description": "The Switch's thumb size (width & height)"},
     {"name": "thumbStyle", "type": "ViewStyle", "description": "The Switch's thumb style"},
     {"name": "style", "type": "ViewStyle", "description": "Custom style"},
-    {"name": "testID", "type": "string", "description": "Component test id"}
+    {"name": "testID", "type": "string", "description": "Component test id"},
+    {"name": "id", "type": "string", "description": "Component id"}
   ],
   "snippet": [
     "<Switch value={false$1} onValueChange={() => console.log('value changed')$2}/>"

src/incubator/TextField/index.tsx

@@ -46,7 +46,7 @@ const TextField = (props: InternalTextFieldProps) => {
   const {
     modifiers,
     // General
-    containerId,
+    containerProps = {},
     fieldStyle: fieldStyleProp,
     dynamicFieldStyle,
     containerStyle,
@@ -124,7 +124,7 @@ const TextField = (props: InternalTextFieldProps) => {
 
   return (
     <FieldContext.Provider value={context}>
-      <View id={containerId} style={[margins, positionStyle, containerStyle, centeredContainerStyle]}>
+      <View {...containerProps} style={[margins, positionStyle, containerStyle, centeredContainerStyle]}>
         <Label
           label={label}
           labelColor={labelColor}

src/incubator/TextField/textField.api.json

@@ -56,6 +56,7 @@
       "type": "ViewStyle | (context: FieldContextType, props) => ViewStyle",
       "description": "Internal style for the field container to style the field underline, outline and fill color"
     },
+    {"name": "containerProps", "type": "Omit<ViewProps, 'style'>", "description": "Container props of the whole component"},
     {"name": "containerStyle", "type": "ViewStyle", "description": "Container style of the whole component"},
     {
       "name": "preset",

src/incubator/TextField/types.ts

@@ -10,6 +10,7 @@ import {
 } from '../../commons/new';
 import {TextProps} from '../../components/text';
 import {PropsWithChildren, ReactElement} from 'react';
+import {ViewProps} from '../../components/view';
 
 export type ColorType =
   | string
@@ -165,9 +166,9 @@ export type TextFieldProps = MarginModifiers &
   ValidationMessageProps &
   Omit<CharCounterProps, 'maxLength' | 'testID'> & {
     /**
-     * Pass id to the container
+     * Pass props to the container
      */
-    containerId?: string;
+    containerProps?: Omit<ViewProps, 'style'>;
     /**
      * Pass to render a leading element
      */