Skip to content

Commit e0d5423

Browse files
authored
Slider - pr comments fix (#2937)
* Slider - pr comments fix * typo
1 parent ef7e387 commit e0d5423

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/components/colorPicker/ColorPickerPreview.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ const styles = StyleSheet.create({
9090
height: 200,
9191
alignItems: 'center',
9292
justifyContent: 'center',
93-
borderBottomWidth: 0.5,
93+
borderBottomWidth: StyleSheet.hairlineWidth,
9494
borderBottomColor: Colors.$outlineDisabled,
95-
borderTopWidth: 0.5,
95+
borderTopWidth: StyleSheet.hairlineWidth,
9696
borderTopColor: Colors.$outlineDisabled
9797
},
9898
inputContainer: {

src/components/slider/GradientSlider.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import _ from 'lodash';
22
import tinycolor from 'tinycolor2';
3-
import React, {useCallback, useEffect, useState, useRef} from 'react';
3+
import React, {useCallback, useEffect, useState, useRef, useMemo} from 'react';
44
import {StyleProp, ViewStyle} from 'react-native';
55
import {Colors} from '../../style';
66
import {asBaseComponent, forwardRef, ForwardRefInjectedProps} from '../../commons/new';
@@ -94,7 +94,7 @@ const GradientSlider = (props: Props) => {
9494
return color || sliderContext.value;
9595
}, [color, sliderContext.value]);
9696

97-
const getHueColor = useCallback(() => {
97+
const hueColor = useMemo(() => {
9898
const color = getColor();
9999
return {
100100
h: color.h,
@@ -113,12 +113,12 @@ const GradientSlider = (props: Props) => {
113113
}, [gradientSteps]);
114114

115115
const renderLightnessGradient = useCallback(() => {
116-
return <Gradient type={Gradient.types.LIGHTNESS} color={getHueColor()} numberOfSteps={gradientSteps}/>;
117-
}, [getHueColor, gradientSteps]);
116+
return <Gradient type={Gradient.types.LIGHTNESS} color={hueColor} numberOfSteps={gradientSteps}/>;
117+
}, [hueColor, gradientSteps]);
118118

119119
const renderSaturationGradient = useCallback(() => {
120-
return <Gradient type={Gradient.types.SATURATION} color={getHueColor()} numberOfSteps={gradientSteps}/>;
121-
}, [getHueColor, gradientSteps]);
120+
return <Gradient type={Gradient.types.SATURATION} color={hueColor} numberOfSteps={gradientSteps}/>;
121+
}, [hueColor, gradientSteps]);
122122

123123
const onValueChange = useCallback((value: string, alpha: number) => {
124124
// alpha returns for type.DEFAULT
@@ -203,7 +203,7 @@ const GradientSlider = (props: Props) => {
203203
step={step}
204204
maximumValue={maximumValue}
205205
value={value}
206-
thumbTintColor={Colors.getHexString(getHueColor())}
206+
thumbTintColor={Colors.getHexString(hueColor)}
207207
onValueChange={sliderOnValueChange}
208208
containerStyle={containerStyle}
209209
disabled={disabled}

0 commit comments

Comments
 (0)